Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix installation order for release-scripts #21586

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Fix installation order for release-scripts #21586

merged 1 commit into from
Jan 1, 2025

Conversation

seanlip
Copy link
Member

@seanlip seanlip commented Jan 1, 2025

Overview

  1. This PR fixes or fixes part of #N/A.
  2. This PR does the following: The Google Cloud installation needs to happen in a certain order for certain paths to be found in release scripts. This PR updates that.

Essential Checklist

Please follow the instructions for making a code change.

  • I have linked the issue that this PR fixes in the "Development" section of the sidebar. (N/A)
  • I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
  • I have written tests for my code.
  • The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes. (N/A)
  • I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

Determined by the install scripts on CI.

@seanlip seanlip requested a review from a team as a code owner January 1, 2025 03:34
@seanlip seanlip requested a review from kevintab95 January 1, 2025 03:34
@oppiabot OppiaBot
Copy link

oppiabot bot commented Jan 1, 2025

Assigning @kevintab95 for the first pass review of this PR. Thanks!

kevintab95
kevintab95 approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@kevintab95 kevintab95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oppiabot OppiaBot
Copy link

oppiabot bot commented Jan 1, 2025

Unassigning @kevintab95 since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jan 1, 2025
@oppiabot OppiaBot
Copy link

oppiabot bot commented Jan 1, 2025

Hi @seanlip, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@seanlip seanlip added this pull request to the merge queue Jan 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 1, 2025
@kevintab95 kevintab95 added this pull request to the merge queue Jan 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 1, 2025
@seanlip
Copy link
Member Author

seanlip commented Jan 1, 2025

Force-merging since this is due to a known flake and we need to merge this to test the build.

@seanlip seanlip merged commit c466558 into develop Jan 1, 2025
131 checks passed
@seanlip seanlip deleted the fix-install-order branch January 1, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevintab95 kevintab95 kevintab95 approved these changes

Assignees

@seanlip seanlip

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanlip @kevintab95