Add GTM support to the Oppia site #21265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigning @Vir-8 for the first pass review of this PR. Thanks! |
Vir-8
approved these changes
Nov 16, 2024
|
Unassigning @Vir-8 since they have already approved the PR. |
|
Assigning @U8NWXD for code owner reviews. Thanks! |
kevintab95
requested changes
Nov 16, 2024
|
Hi @seanlip, it looks like some changes were requested on this pull request by @kevintab95. PTAL. Thanks! |
kevintab95
approved these changes
Nov 17, 2024
kevintab95
pushed a commit
that referenced
this pull request
Nov 18, 2024
* Add GTM support. * Add logic for updating configs * Update gtm code
kevintab95
pushed a commit
that referenced
this pull request
Nov 18, 2024
* Add GTM support. * Add logic for updating configs * Update gtm code
kevintab95
added
the
PR: Needs to be hotfixed
|
Hi, @oppia/release-coordinators flagging this pull request for for your attention since this is labelled as a hotfix PR. Please ensure that you add the "PR: for current release" label if the next release is in progress. Thanks! |
kevintab95
added
PR: for current release
and removed
PR: for current release
PR: Needs to be hotfixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Essential Checklist
Please follow the instructions for making a code change.
Testing doc (for PRs with Beam jobs that modify production server data)
Proof that changes are correct
This will be determined based on the server testing above.