Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #20922 : Ensure 'Create New Topics/Skills' button is always visible on mobile #20998

Merged

Conversation

TARishabh
Copy link
Collaborator

@TARishabh TARishabh commented Sep 25, 2024

Overview

  1. This PR fixes or fixes part of #[20922].
  2. This PR ensures that the "Create New Topics/Skills" button is always visible on mobile by adding a z-index of 99 to its styling. This change prevents the button from being hidden behind other elements, improving visibility and usability.
  3. The original bug occurred because the button did not have a high enough z-index, causing it to be obscured by other elements on the mobile view. This made it appear only when scrolling to the bottom of the page.

Essential Checklist

Please follow the instructions for making a code change.

  • I have linked the issue that this PR fixes in the "Development" section of the sidebar.
  • I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
  • I have written tests for my code.
  • The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
  • I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

Before:
Shown in the issue #20922

After:
Screencast from 25-09-24 09:23:51 PM IST.webm

PR Pointers

@TARishabh TARishabh requested a review from a team as a code owner September 25, 2024 15:55
@TARishabh TARishabh requested a review from Nik-09 September 25, 2024 15:55
Copy link

oppiabot bot commented Sep 25, 2024

Assigning @Nik-09 for the first pass review of this PR. Thanks!

@TARishabh
Copy link
Collaborator Author

Hey @Nik-09 , PTAL !!

Copy link
Member

@Nik-09 Nik-09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @TARishabh

@Nik-09 Nik-09 added this pull request to the merge queue Sep 26, 2024
@oppiabot oppiabot bot unassigned Nik-09 Sep 26, 2024
Copy link

oppiabot bot commented Sep 26, 2024

Unassigning @Nik-09 since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Sep 26, 2024
Copy link

oppiabot bot commented Sep 26, 2024

Hi @TARishabh, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2024
@seanlip seanlip merged commit 93bd89a into oppia:develop Sep 26, 2024
79 checks passed
Copy link

Thanks @TARishabh, and congratulations on your first PR to Oppia! 🎉 🥳
Feel free to take up a second issue if you'd like to help out more!

Developer onboarding lead : @HardikGoyal2003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants