-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #1464: implement the collection editor node list #1993
Merged
BenHenning
merged 38 commits into
collection-editor-first-iteration
from
collection-node-list
Jun 5, 2016
Merged
Fix part of #1464: implement the collection editor node list #1993
BenHenning
merged 38 commits into
collection-editor-first-iteration
from
collection-node-list
Jun 5, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection-node-list
Fix part of #1464: implement the collection editor node list (PR 1/2; this is to bring Abe's changes into the central Oppia respository)
…-list Conflicts: core/templates/dev/head/collection_editor/editor_tab/CollectionNodeCreatorDirective.js core/templates/dev/head/collection_editor/editor_tab/collection_details_editor_directive.html core/templates/dev/head/collection_editor/editor_tab/collection_main_tab_directive.html
into a single source: CollectionLinearizerService. This service helps with inserting and deleting nodes. It also led to simpler validation logic and a much simpler filter for the collection node viewer. Tests still need to be added for this new service.
collection node list editor.
joshuacano
pushed a commit
to joshuacano/oppia
that referenced
this pull request
Jun 14, 2016
…pia#1993) Provides a base implementation for the collection editor node list without dragging being used for scrolling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is replacing #1687 by moving it to a staged feature branch.