Fix #10647: Fixed faulty navbar on topic editor #19567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigning @Lawful2002 for the first pass review of this PR. Thanks! |
|
@seanlip PTAL |
…bar-on-topic-editor
|
@masterboy376 The codeowner for this PR is @Lawful2002, so I'll defer to him for the review. |
Lawful2002
suggested changes
Jan 24, 2024
There was a problem hiding this comment.
Thanks for the PR @masterboy376,
One question, in the first video you provided how did you navigate to the topic editor page (around 0:29 in the video), as I was not able to see your cursor.
Also one code comment.
PTAL, thanks!
core/templates/pages/topic-editor-page/navbar/topic-editor-navbar.component.ts
Outdated
Show resolved
Hide resolved
|
@Lawful2002 PTAL |
|
Unassigning @masterboy376 since a re-review was requested. @masterboy376, please make sure you have addressed all review comments. Thanks! |
…bar-on-topic-editor
Lawful2002
approved these changes
Jan 28, 2024
|
Unassigning @Lawful2002 since they have already approved the PR. |
|
Hi @masterboy376, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Aakash-Jakhmola
pushed a commit
to Aakash-Jakhmola/oppia
that referenced
this pull request
Jan 30, 2024
* fixed the navbar on subtopic page and also added necessary tests * removed unnecessary function * fixed coverage issues * added dynamic icon in navbar * fixed some linting issues * simplified the boolean expression
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
…butor admin dashboard (#19594) * fix language name in language dropdown to list language name first * change var to let * fix integration test * Fix #19511: make name optional for subscribing (#19534) * fix #19511: make name optional for subscribing * fix lint * use Optional * return non_empty validator * remove Union * Fix #18661: Specific partnership interest form for each language (#19402) * Fix #18661: specific partnership form link * linting * frontend tests * ts-checks * fixes * minor changes * resolve conflict * fix tests * Fix issue #19408 About Page is not responsive (#19530) changes done in about-page.component.css Co-authored-by: 2008sahil <getinter6@gmail.com> * Fix #18512: Graph Interaction Mobile Grey Out Bug (#19532) * Fix Reset Button Styling on Graph * Change to Flow Root * Fix #18079: Add fixed height to Skill dialogbox (#19558) * added fixed height * fixed search bar * lint --------- Co-authored-by: Nikita Vorobev <vorobyev.nikita@gmail.com> * Fix #19398 Added make stop in case of non zero exit code (#19483) * Trap command used to check for Sudden Exit of running tests on code * trap command is added with sigint handler * trap command is added with sigint handler * trap command is added with sigint handler * trap command is added with sigint handler * trap command is added with sigint handler * changed done as reuqired * coe updated to check for exit aprt from keyboard interrupt also * code for all tests updated in makeflie to stop containers in any case of failure * code for all tests updated in makeflie to stop containers in any case of failure * make stop will executed for all exit code apart from 0 now * removed extra spaces * removed the extra echo commands * backend tests workflow changed * backend tests workflow changed * removed the extra echo commands * Fixes google-chrome not found for Mac users in Docker setup (#19512) * fix: chrome version for mac * chore: removed newlines * chore: refracted the variables name * Fix #19545: Exploration editor category creating new categories when selecting old ones. (#19549) * Fix Exploration Editor Category Select * Change to Value Change * Fix #19536: Adds hover effect to subscribe button on android page (#19565) * button replaced by primary-button in android page, also disabled attribute added * fix linter error * Creates voiceover language policy model (#19456) * Creates voiceover model * Adds test for entity voiceover model * Add voiceover domain and service methods. * Adds voiceover domain and services tests * Fixes mypy checks * Creates voiceover policy model * Fixes linter issues. * Address review comments * Adds regex check for language accent code * Updates voiceover policy model name. * Adds voiceover language accent constants * Adds language accent codes list for voiceovers * updates docstring * updates docstring * Deletes voice policy dir and shifts it into voiceover dir * Adds helper methods to get & save in VoiceoverAutogenerationPolicyModel * Creates json files to stores L-a constants. * Adds test to validate voiceover language accent constants. * Removes dead code * Updates code comment * Updates code comment * Updates Readme. * Adds note to developers * Updates code comment * GSoC_2.5: Frontend changes to enable pinning of opportunties (#19122) * Front-end changes * Fix frontend tests * Fix frontend tests * Fix linting * Fix tests * Fix tests * Fix tests * Fix linting * Fix linting * Fix linting * Fix CI checks * Fix all linting errors * Update the frontend files and write unit tests * Fix failing unit tests * Fix failing unit tests * Fix failing unit tests * Fix failing unit tests * Fix failing CI checks * Fix failing unit tests * Fix CI Checks * Fix lint checks * Fix typescript typecheck errors * Fix typescript typecheck errors * Fix typescript typecheck errors * Address Review Comments * Fix flaky tests * Fix lints and add coverage tests * Fix lints and add coverage tests * Fix #15377: Interaction changes still remain in pop-up after cancellation (#19579) Fix Customization Args Saved Memento * Fix issue #19576:Library Page Search Results Alignment Issue (#19588) searched results alligned to center Co-authored-by: 2008sahil <getinter6@gmail.com> * use regex for matching * change regex * Fix #19516: Navigation issues in the blog author page (#19517) fix: Navigation issues in the blog author page * fix : [BUG]: Cursor should be hand pointer instead of text pointer #19575 (#19584) * Click-Arrow edit button text solved * some minor fixes * Fix issue #19407:Blog page is not responsive on mobile devices (#19474) * fixed UI changes in blog page * passing lint testcase1 * passing lint testcase2 * all lint case passed * all lint case passed * final commit * done suggested changes * Suggested Changes Done * added media query at 470px * fixed UI changes in blog page * passing lint testcase1 * passing lint testcase2 * all lint case passed * all lint case passed * final commit * done suggested changes * Suggested Changes Done * Resolved responsive issues in blog page * solved responsive issues * added margin to blog-navigate icon * fixed all changes * linter issue resolved * linter issue resolved * all linter checks resolved * changed naming to no-result-found --------- Co-authored-by: 2008sahil <getinter6@gmail.com> * FIX #19571 : Add a space after "or" Conjunction and Second Option in Exploration Multi-selection. (#19573) {{Fix spacing with OR}} Co-authored-by: Sean Lip <sean@seanlip.org> * Fix #10647: Fixed faulty navbar on topic editor (#19567) * fixed the navbar on subtopic page and also added necessary tests * removed unnecessary function * fixed coverage issues * added dynamic icon in navbar * fixed some linting issues * simplified the boolean expression * Fix #19507: Corrected responsive design for exploration editor nav tools (#19600) Fixed responsive issue with exploration editor * Remove unused dependencies: `py` (via `pytest` upgrade)and `PyGithub` (#19553) * removed unused deps * removed unused tests * upgraded pytest to 7.4.4 * fix regex * fix docstring * fix tests * fix test * fix test --------- Co-authored-by: Nikita Vorobev <vorobyev.nikita@gmail.com> Co-authored-by: Yashwardhan Jyani <100014271+yashwardhan-jyani@users.noreply.github.com> Co-authored-by: Sahil Gupta <155609546+2008sahil@users.noreply.github.com> Co-authored-by: 2008sahil <getinter6@gmail.com> Co-authored-by: Justin Nguyen <70992422+jnvtnguyen@users.noreply.github.com> Co-authored-by: Harsh Keshari <108923011+hrshkshri@users.noreply.github.com> Co-authored-by: Yash Dugriyal <127002519+yash1378@users.noreply.github.com> Co-authored-by: Akash Jaiswal <akashjaiswal3846@gmail.com> Co-authored-by: sagar-subedi <66303548+sagar-subedi@users.noreply.github.com> Co-authored-by: Nikhil <nikhil.agarwal.2019@gmail.com> Co-authored-by: Ashwath Kannan <98253080+Ash-2k3@users.noreply.github.com> Co-authored-by: Afzal Khan <tricktomade@gmail.com> Co-authored-by: Yogesh Saini <97088265+Ykumar1415@users.noreply.github.com> Co-authored-by: Rahat <136263179+rahat2134@users.noreply.github.com> Co-authored-by: Sean Lip <sean@seanlip.org> Co-authored-by: Sambhav Kaushik <92575005+masterboy376@users.noreply.github.com> Co-authored-by: amyyeung17 <amyyeung17@gmail.com> Co-authored-by: Harshvardhan Singh <73544247+Lawful2002@users.noreply.github.com>
jayam04
pushed a commit
to jayam04/oppia
that referenced
this pull request
Feb 21, 2024
…ontributor admin dashboard (oppia#19594) * fix language name in language dropdown to list language name first * change var to let * fix integration test * Fix oppia#19511: make name optional for subscribing (oppia#19534) * fix oppia#19511: make name optional for subscribing * fix lint * use Optional * return non_empty validator * remove Union * Fix oppia#18661: Specific partnership interest form for each language (oppia#19402) * Fix oppia#18661: specific partnership form link * linting * frontend tests * ts-checks * fixes * minor changes * resolve conflict * fix tests * Fix issue oppia#19408 About Page is not responsive (oppia#19530) changes done in about-page.component.css Co-authored-by: 2008sahil <getinter6@gmail.com> * Fix oppia#18512: Graph Interaction Mobile Grey Out Bug (oppia#19532) * Fix Reset Button Styling on Graph * Change to Flow Root * Fix oppia#18079: Add fixed height to Skill dialogbox (oppia#19558) * added fixed height * fixed search bar * lint --------- Co-authored-by: Nikita Vorobev <vorobyev.nikita@gmail.com> * Fix oppia#19398 Added make stop in case of non zero exit code (oppia#19483) * Trap command used to check for Sudden Exit of running tests on code * trap command is added with sigint handler * trap command is added with sigint handler * trap command is added with sigint handler * trap command is added with sigint handler * trap command is added with sigint handler * changed done as reuqired * coe updated to check for exit aprt from keyboard interrupt also * code for all tests updated in makeflie to stop containers in any case of failure * code for all tests updated in makeflie to stop containers in any case of failure * make stop will executed for all exit code apart from 0 now * removed extra spaces * removed the extra echo commands * backend tests workflow changed * backend tests workflow changed * removed the extra echo commands * Fixes google-chrome not found for Mac users in Docker setup (oppia#19512) * fix: chrome version for mac * chore: removed newlines * chore: refracted the variables name * Fix oppia#19545: Exploration editor category creating new categories when selecting old ones. (oppia#19549) * Fix Exploration Editor Category Select * Change to Value Change * Fix oppia#19536: Adds hover effect to subscribe button on android page (oppia#19565) * button replaced by primary-button in android page, also disabled attribute added * fix linter error * Creates voiceover language policy model (oppia#19456) * Creates voiceover model * Adds test for entity voiceover model * Add voiceover domain and service methods. * Adds voiceover domain and services tests * Fixes mypy checks * Creates voiceover policy model * Fixes linter issues. * Address review comments * Adds regex check for language accent code * Updates voiceover policy model name. * Adds voiceover language accent constants * Adds language accent codes list for voiceovers * updates docstring * updates docstring * Deletes voice policy dir and shifts it into voiceover dir * Adds helper methods to get & save in VoiceoverAutogenerationPolicyModel * Creates json files to stores L-a constants. * Adds test to validate voiceover language accent constants. * Removes dead code * Updates code comment * Updates code comment * Updates Readme. * Adds note to developers * Updates code comment * GSoC_2.5: Frontend changes to enable pinning of opportunties (oppia#19122) * Front-end changes * Fix frontend tests * Fix frontend tests * Fix linting * Fix tests * Fix tests * Fix tests * Fix linting * Fix linting * Fix linting * Fix CI checks * Fix all linting errors * Update the frontend files and write unit tests * Fix failing unit tests * Fix failing unit tests * Fix failing unit tests * Fix failing unit tests * Fix failing CI checks * Fix failing unit tests * Fix CI Checks * Fix lint checks * Fix typescript typecheck errors * Fix typescript typecheck errors * Fix typescript typecheck errors * Address Review Comments * Fix flaky tests * Fix lints and add coverage tests * Fix lints and add coverage tests * Fix oppia#15377: Interaction changes still remain in pop-up after cancellation (oppia#19579) Fix Customization Args Saved Memento * Fix issue oppia#19576:Library Page Search Results Alignment Issue (oppia#19588) searched results alligned to center Co-authored-by: 2008sahil <getinter6@gmail.com> * use regex for matching * change regex * Fix oppia#19516: Navigation issues in the blog author page (oppia#19517) fix: Navigation issues in the blog author page * fix : [BUG]: Cursor should be hand pointer instead of text pointer oppia#19575 (oppia#19584) * Click-Arrow edit button text solved * some minor fixes * Fix issue oppia#19407:Blog page is not responsive on mobile devices (oppia#19474) * fixed UI changes in blog page * passing lint testcase1 * passing lint testcase2 * all lint case passed * all lint case passed * final commit * done suggested changes * Suggested Changes Done * added media query at 470px * fixed UI changes in blog page * passing lint testcase1 * passing lint testcase2 * all lint case passed * all lint case passed * final commit * done suggested changes * Suggested Changes Done * Resolved responsive issues in blog page * solved responsive issues * added margin to blog-navigate icon * fixed all changes * linter issue resolved * linter issue resolved * all linter checks resolved * changed naming to no-result-found --------- Co-authored-by: 2008sahil <getinter6@gmail.com> * FIX oppia#19571 : Add a space after "or" Conjunction and Second Option in Exploration Multi-selection. (oppia#19573) {{Fix spacing with OR}} Co-authored-by: Sean Lip <sean@seanlip.org> * Fix oppia#10647: Fixed faulty navbar on topic editor (oppia#19567) * fixed the navbar on subtopic page and also added necessary tests * removed unnecessary function * fixed coverage issues * added dynamic icon in navbar * fixed some linting issues * simplified the boolean expression * Fix oppia#19507: Corrected responsive design for exploration editor nav tools (oppia#19600) Fixed responsive issue with exploration editor * Remove unused dependencies: `py` (via `pytest` upgrade)and `PyGithub` (oppia#19553) * removed unused deps * removed unused tests * upgraded pytest to 7.4.4 * fix regex * fix docstring * fix tests * fix test * fix test --------- Co-authored-by: Nikita Vorobev <vorobyev.nikita@gmail.com> Co-authored-by: Yashwardhan Jyani <100014271+yashwardhan-jyani@users.noreply.github.com> Co-authored-by: Sahil Gupta <155609546+2008sahil@users.noreply.github.com> Co-authored-by: 2008sahil <getinter6@gmail.com> Co-authored-by: Justin Nguyen <70992422+jnvtnguyen@users.noreply.github.com> Co-authored-by: Harsh Keshari <108923011+hrshkshri@users.noreply.github.com> Co-authored-by: Yash Dugriyal <127002519+yash1378@users.noreply.github.com> Co-authored-by: Akash Jaiswal <akashjaiswal3846@gmail.com> Co-authored-by: sagar-subedi <66303548+sagar-subedi@users.noreply.github.com> Co-authored-by: Nikhil <nikhil.agarwal.2019@gmail.com> Co-authored-by: Ashwath Kannan <98253080+Ash-2k3@users.noreply.github.com> Co-authored-by: Afzal Khan <tricktomade@gmail.com> Co-authored-by: Yogesh Saini <97088265+Ykumar1415@users.noreply.github.com> Co-authored-by: Rahat <136263179+rahat2134@users.noreply.github.com> Co-authored-by: Sean Lip <sean@seanlip.org> Co-authored-by: Sambhav Kaushik <92575005+masterboy376@users.noreply.github.com> Co-authored-by: amyyeung17 <amyyeung17@gmail.com> Co-authored-by: Harshvardhan Singh <73544247+Lawful2002@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Essential Checklist
Proof that changes are correct
1.webm
Proof of changes on desktop with slow/throttled network
2.webm
Proof of changes on mobile phone
1.webm
Proof of changes in Arabic language
PR Pointers