Fix #1697: upgrade collection schema version to 2 by introducing language codes to collections (where the default is 'en'). #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its schema version to 2, where new collection have a default language code of 'en'. The support for this language code has been implemented end-to-end for collections, including in the collection creation dialog and for search queries (though this commit does not implement collection searching).
|
/cc @amgowano |
| @@ -198,7 +201,7 @@ oppia.factory('CollectionUpdateService', [ | |||
| }, | |||
|
|
|||
| /** | |||
| * Changes the title of a category and records the change in the | |||
|
LGTM -- looks fantastic. Thanks @BenHenning! OK to merge when Travis checks pass. |
|
Thanks for the review, @seanlip! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a language_code to the collection data structure and updated its schema version to 2, where new collection have a default language code of 'en'. The support for this language code has been implemented end-to-end for collections, including in the collection creation dialog and for search queries (though this commit does not implement collection searching).