Update JSCS to v3.0.3 #1849
Merged
Update JSCS to v3.0.3 #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 47.92%@@ develop #1849 diff @@
==========================================
Files 179 179
Lines 15198 15198
Methods 2616 2616
Messages 0 0
Branches 2564 2564
==========================================
Hits 7283 7283
Misses 7915 7915
Partials 0 0
|
| @@ -17,7 +17,6 @@ | |||
| "fileExtensions": [".js"], | |||
| "extract": ["*.html"], | |||
| "maxErrors": null, | |||
| "verbose": true, | |||
There was a problem hiding this comment.
verbose is true by default (according to a warning by JSCS when I ran it)
so we can remove this.
On Tue, May 17, 2016 at 9:40 PM, Sean Lip notifications@github.com wrote:
In .jscsrc #1849 (comment)
:@@ -17,7 +17,6 @@
"fileExtensions": [".js"],
"extract": ["*.html"],
"maxErrors": null,
- "verbose": true,
why?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/oppia/oppia/pull/1849/files/47fe9d59a729b2f80621a3fbfccb24da1c7466ee#r63644140
There was a problem hiding this comment.
Ah ok, thanks for the explanation. LGTM then!
|
Looks good generally -- just one comment! |
seanlip
added
IN REVIEW - don't merge
PR: LGTM
and removed
IN REVIEW - don't merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates JSCS to v3.0.3 and fix corresponding the linter errors.