Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the title of the first box of the feature request form #16527

Merged
merged 1 commit into from
Nov 12, 2022

Conversation

gp201
Copy link
Contributor

@gp201 gp201 commented Nov 12, 2022

Overview

  1. This PR fixes or fixes part of N/A
  2. This PR does the following: Change the title of the first box to make it clearer.

The label attribute the title of the box and the description attribute is the subtext.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

Proof of changes on desktop with slow/throttled network

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL". Oppiabot will help assign that person for you.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

@gp201 gp201 requested a review from a team as a code owner November 12, 2022 00:47
@gp201 gp201 requested a review from U8NWXD November 12, 2022 00:47
@oppiabot
Copy link

oppiabot bot commented Nov 12, 2022

Hi, @gp201, this pull request does not have a "CHANGELOG: ..." label as mentioned in the PR pointers. Assigning @gp201 to add the required label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@oppiabot oppiabot bot assigned gp201 Nov 12, 2022
@gp201 gp201 assigned U8NWXD and unassigned gp201 Nov 12, 2022
@U8NWXD U8NWXD merged commit cefc6a9 into oppia:develop Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants