Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic test session #16489

Merged
merged 196 commits into from
Nov 23, 2022
Merged

Diagnostic test session #16489

merged 196 commits into from
Nov 23, 2022

Conversation

Nik-09
Copy link
Member

@Nik-09 Nik-09 commented Nov 4, 2022

Overview

The PR adds the UI to give the diagnostic test from the diagnostic test player page. And, based on the performance in the test, 0, or 1, or 2 topics were recommended.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

Updated screenshots
Screenshot (11)
Screenshot from 2022-11-22 14-45-35
Screenshot from 2022-11-22 14-37-31
Screenshot from 2022-11-22 14-32-34
Screenshot from 2022-11-22 14-16-24

two.mp4
three.mp4

Existing exploration editor and player

exploration.mp4

Existing practice session

practice_session.mp4

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL". Oppiabot will help assign that person for you.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

Nik-09 added 30 commits October 10, 2022 22:32
@seanlip seanlip removed their assignment Nov 22, 2022
core/tests/webdriverio_utils/ClassroomPage.js Outdated Show resolved Hide resolved
core/tests/webdriverio_utils/ExplorationPlayerPage.js Outdated Show resolved Hide resolved
core/tests/webdriverio_utils/DiagnosticTestPage.js Outdated Show resolved Hide resolved
core/tests/webdriverio_utils/DiagnosticTestPage.js Outdated Show resolved Hide resolved
core/tests/webdriverio_utils/DiagnosticTestPage.js Outdated Show resolved Hide resolved
core/tests/webdriverio_desktop/diagnosticTestPage.js Outdated Show resolved Hide resolved
core/tests/webdriverio_desktop/diagnosticTestPage.js Outdated Show resolved Hide resolved
@oppiabot oppiabot bot unassigned U8NWXD Nov 22, 2022
@oppiabot
Copy link

oppiabot bot commented Nov 22, 2022

Unassigning @U8NWXD since the review is done.

@oppiabot
Copy link

oppiabot bot commented Nov 22, 2022

Hi @Nik-09, it looks like some changes were requested on this pull request by @U8NWXD. PTAL. Thanks!

Copy link
Member Author

@Nik-09 Nik-09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @U8NWXD thank you for the review, I have addressed the comments.
Please take a look at the nearest time when you are available.
Thank you.

@Nik-09 Nik-09 assigned U8NWXD and unassigned Nik-09 Nov 23, 2022
@dchen97
Copy link
Contributor

dchen97 commented Nov 23, 2022

Thanks @Nik-09 ! This LGTM

@dchen97 dchen97 removed their assignment Nov 23, 2022
@U8NWXD U8NWXD assigned Nik-09 and unassigned U8NWXD Nov 23, 2022
@Nik-09 Nik-09 assigned U8NWXD and unassigned Nik-09 Nov 23, 2022
@U8NWXD U8NWXD assigned Nik-09 and unassigned U8NWXD Nov 23, 2022
@oppiabot oppiabot bot added the PR: LGTM label Nov 23, 2022
@oppiabot
Copy link

oppiabot bot commented Nov 23, 2022

Hi @Nik-09, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@Nik-09 Nik-09 enabled auto-merge (squash) November 23, 2022 18:57
@Nik-09 Nik-09 merged commit c6c6f56 into oppia:develop Nov 23, 2022
gp201 added a commit that referenced this pull request Nov 23, 2022
seanlip pushed a commit that referenced this pull request Nov 24, 2022
Revert "Diagnostic test session (#16489)"

This reverts commit c6c6f56.
@seanlip seanlip mentioned this pull request Nov 24, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants