Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing Uploading Images Larger than 1KB for blog #16479

Merged
merged 12 commits into from
Nov 8, 2022

Conversation

Rijuta-s
Copy link
Contributor

@Rijuta-s Rijuta-s commented Nov 3, 2022

Overview

  1. This PR fixes or fixes part of NA
  2. This PR does the following: Allows to upload image size larger than 1Kb till 1MB for blog.
    Also it fixes generating blog post summary string.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

RTEs other than Blog RTEs:

ScreenRecorder_2022-11-03_1f89e1de-5339-4ffe-b7b1-f269668a8b7c.mp4

Allows images only till 100KB

Blog RTE:

ScreenRecorder_2022-11-03_64b0e55e-2a06-4083-ab8f-7c0480ef78ba.mp4

Allows image till 1MB

Blog Post Card:
Before:
Screenshot from 2022-11-04 05-09-37

After:
Screenshot from 2022-11-04 05-11-21

Proof of changes on desktop with slow/throttled network

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL". Oppiabot will help assign that person for you.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

Sorry, something went wrong.

@oppiabot
Copy link

oppiabot bot commented Nov 3, 2022

Hi @Rijuta-s please assign the required reviewer(s) for this PR. Thanks!

@Rijuta-s Rijuta-s marked this pull request as ready for review November 3, 2022 14:03
@Rijuta-s Rijuta-s requested review from a team November 3, 2022 14:03
@Rijuta-s Rijuta-s requested a review from a team as a code owner November 3, 2022 14:03
@Rijuta-s Rijuta-s requested a review from a team November 3, 2022 14:03
@Rijuta-s Rijuta-s requested a review from a team as a code owner November 3, 2022 14:03
@Rijuta-s
Copy link
Contributor Author

Rijuta-s commented Nov 3, 2022

@vojtechjelinek @gp201 @iamprayush @aks681 PTAL!
Thank you

Copy link
Contributor

@gp201 gp201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gp201 gp201 removed their assignment Nov 3, 2022
Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oppiabot
Copy link

oppiabot bot commented Nov 4, 2022

Unassigning @vojtechjelinek since they have already approved the PR.

Copy link
Contributor

@iamprayush iamprayush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for codeowner files, thanks!

@iamprayush iamprayush removed their assignment Nov 5, 2022
@kevintab95 kevintab95 self-requested a review November 8, 2022 08:54
Copy link
Contributor

@aks681 aks681 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@aks681 aks681 merged commit c0add9e into oppia:develop Nov 8, 2022
@Rijuta-s Rijuta-s deleted the image-upload-blog branch November 8, 2022 09:11
vojtechjelinek pushed a commit that referenced this pull request Nov 10, 2022
* Allowing 1MB files for blog posts

* fixing mypy checks

* Fixing lint checks

* fixing backend tests

* unescaping html

* Applying suggestions for blog dashboard

* FIxing frontend tests
kevintab95 pushed a commit that referenced this pull request Nov 12, 2022
* Allowing 1MB files for blog posts

* fixing mypy checks

* Fixing lint checks

* fixing backend tests

* unescaping html

* Applying suggestions for blog dashboard

* FIxing frontend tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants