Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes part of #9749: Migrate few instances of angular-html-bind #14263

Merged
merged 7 commits into from
Nov 27, 2021
Merged

Fixes part of #9749: Migrate few instances of angular-html-bind #14263

merged 7 commits into from
Nov 27, 2021

Conversation

srijanreddy98
Copy link
Member

@srijanreddy98 srijanreddy98 commented Nov 16, 2021 •
edited
Loading

Overview

  1. This PR fixes or fixes part of Migrate directives/controllers to Angular components #9749.
  2. This PR does the following: Migrates some angular html bind instances that show rte output.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

https://drive.google.com/file/d/1hJooUAgGpvFVTsYBtBIjQddUWaIKEDcE/view?usp=sharing
https://drive.google.com/file/d/1GR1ehPlU0RiD-B9iZcjuSj5q7d7UKw-V/view?usp=sharing

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Oppiabot can assign anyone for review/help if you leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL"
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

@oppiabot
Copy link

oppiabot bot commented Nov 16, 2021

Hi @srijanreddy98, can you complete the following:

  1. The body of this PR is missing the required description, please update the body with a description of what this PR does.
  2. The proof that changes are correct has not been provided, please make sure to upload a image/video showing that the changes are correct. Or include a sentence saying "No proof of changes needed because" and the reason why proof of changes cannot be provided.
    Thanks!

@oppiabot
Copy link

oppiabot bot commented Nov 16, 2021

Hi, @srijanreddy98, this pull request does not have a "CHANGELOG: ..." label as mentioned in the PR pointers. Assigning @srijanreddy98 to add the required label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@srijanreddy98 srijanreddy98 marked this pull request as ready for review November 17, 2021 09:39
@srijanreddy98 srijanreddy98 requested a review from a team November 17, 2021 09:39
@srijanreddy98 srijanreddy98 requested a review from a team as a code owner November 17, 2021 09:39
@srijanreddy98 srijanreddy98 requested review from a team and U8NWXD November 17, 2021 09:39
@oppiabot
Copy link

oppiabot bot commented Nov 17, 2021

Assigning @vojtechjelinek, @kevintab95, @nithusha21, @DubeySandeep, @U8NWXD, @EricZLou, @aks681, @Hudda, @iamprayush for code owner reviews. Thanks!

@seanlip
Copy link
Member

seanlip commented Nov 27, 2021

I am merging this because it is needed for the release and @iamprayush's comment is addressed.

@iamprayush Please take a look when you can and confirm that you have no further comments. Thanks!

@seanlip seanlip mentioned this pull request Nov 27, 2021
Open
@seanlip seanlip disabled auto-merge November 27, 2021 07:19
@seanlip seanlip merged commit d74038b into oppia:develop Nov 27, 2021
seanlip pushed a commit that referenced this pull request Nov 27, 2021
@srijanreddy98 @seanlip
Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)
145182d 
* Revert "Revert "Fix part of #9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (#13229)" (#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.

Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>
seanlip pushed a commit that referenced this pull request Nov 27, 2021
@srijanreddy98 @seanlip
Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)
93aca6f 
* Revert "Revert "Fix part of #9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (#13229)" (#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.
srijanreddy98 pushed a commit to srijanreddy98/oppia that referenced this pull request Nov 27, 2021
@kingjuno
Fix part of oppia#14033: Add Mypy type annotations to domain files (o…
7e57e97 
…ppia#14058)

Fix oppia#14235: Enable to submit question suggestions with image region interations (oppia#14289)

* First pass

* Fix lint

* Fix lint

* Fix ts checks

* Fix lint

* Fix f-e test

* Fix f-e test

* Fix backend tests

* Fix backend test

* Fix lints

* Fix backend tests

* Fix lints

* Fix backend tests

* Fix lints

* Fix backend coverage

* Fix backend tests

* Copy images to required destination after acceptance

* Fix lint

* Fix ts checks

* Remove image destination reset

* Address reviews

* Fix backend errors

* Fix backend errors

* Fix backend errors

* Fix backend errors

* Fix backend errors

* Fix lint

* Fix backend tests

* Fix lint

* Fix nits

* Add more backend tests

* Fix lints

* Address review requests

* Fix nits

* Fix nits

* Fix b-e tests

Fixes part of oppia#9749: Migrate few instances of angular-html-bind (oppia#14263)

* Revert "Revert "Fix part of oppia#9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (oppia#13229)" (oppia#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.
srijanreddy98 added a commit to srijanreddy98/oppia that referenced this pull request Nov 27, 2021
@srijanreddy98
Fixes part of oppia#9749: Migrate few instances of angular-html-bind (o…
a88cf33 
…ppia#14263)

* Revert "Revert "Fix part of oppia#9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (oppia#13229)" (oppia#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.

Fixes part of oppia#9749: Migrate few instances of angular-html-bind (oppia#14263)

* Revert "Revert "Fix part of oppia#9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (oppia#13229)" (oppia#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.
seanlip pushed a commit that referenced this pull request Nov 27, 2021
@srijanreddy98 @seanlip
Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)
3996a61 
* Revert "Revert "Fix part of #9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (#13229)" (#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.
seanlip added a commit that referenced this pull request Nov 27, 2021
@seanlip
Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)
443873c 
* Revert "Revert "Fix part of #9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (#13229)" (#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.
seanlip added a commit that referenced this pull request Nov 27, 2021
@seanlip
Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)
bacadf6 
* Revert "Revert "Fix part of #9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (#13229)" (#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.
seanlip added a commit that referenced this pull request Nov 27, 2021
@seanlip
Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)
f74b606 
* Revert "Revert "Fix part of #9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (#13229)" (#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.
seanlip added a commit that referenced this pull request Nov 27, 2021
@seanlip
Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)
4bf8959 
* Revert "Revert "Fix part of #9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (#13229)" (#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.
@iamprayush
Copy link
Contributor

I am merging this because it is needed for the release and @iamprayush's comment is addressed.

@iamprayush Please take a look when you can and confirm that you have no further comments. Thanks!

My comment has been addressed, thanks!

Nik-09 pushed a commit that referenced this pull request Dec 3, 2021
@SD-13 @srijanreddy98
Fix Part of #13162: Add argument schema for ExplorationCompleteEventH…
dd898b9 
…andler, ExplorationMaybeLeaveHandler, SolutionHitEventHandler classes (#14208)

* adds schema for few handlers

* updated according to lint checks

* replaced constants and added few suggested changes

* removed an unused import

* updated schema for params arg

* updated according to lint checks

* updated few schema and tests

* updated with lint checks

* added rules in few handler args

* adds rules in params schema

* updated the schema

* removed handler names from HANDLER_CLASS_NAMES_WHICH_STILL_NEED_SCHEMAS list

* updated a test for params

* adds a test for params

* Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)

* Revert "Revert "Fix part of #9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (#13229)" (#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.

Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>

* adds test for params value

* adds test for params invalid data

* fixed lint checks

* updated rules

* adds check for invalid key

* adds a test

* removed tests and updated the rules

* added test for the rules

Co-authored-by: Srijan Reddy <srijan@srijanreddy.com>
Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>
srijanreddy98 added a commit that referenced this pull request Dec 6, 2021
@heyimShivam @srijanreddy98
Fix part of #8016: Migration of Exploration rights Service from Angul…
d405dba 
…arJS to Angular (#14278)

* first commit

* 80 max-len

* year Change

* semicolon error by checks solved

* ashu changes

* done

* solved e2e test case

* front end complete may e2e test resolved

* test case fro exploration-rights done

* minor change left i.e. variable update (overal all file completed)

* lint check

* lint issue

* rename

* restored

* useless nits

* rootScope Apply

* change in frontend test case solved 100 percent cover

* url changes

* auto indent remove

* try to solve lint issue

* Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)

* Revert "Revert "Fix part of #9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (#13229)" (#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.



* testing improved

* same name

* one more serive mig

* changes made

* done

* some left

* some left

* to be null

* suggest changes

* changing name

* e2e resolve

* naming improved

Co-authored-by: Srijan Reddy <srijan@srijanreddy.com>
@aishwary023 aishwary023 mentioned this pull request Dec 16, 2021
Merged
4 tasks
nithusha21 pushed a commit that referenced this pull request Dec 18, 2021
@sahiljoster32 @srijanreddy98
Fix #14404: Fixes sidebar freezing behaviour (#14420)
6c23f48 
* Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)

* Revert "Revert "Fix part of #9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (#13229)" (#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.

Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>

* pending with tests

* added event

* added respective tests

Co-authored-by: Srijan Reddy <srijan@srijanreddy.com>
Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>
aks681 pushed a commit that referenced this pull request Jan 4, 2022
@sahiljoster32 @srijanreddy98 @aks681
Fix #14404: Fixes sidebar freezing behaviour (#14420)
32c0fc2 
* Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)

* Revert "Revert "Fix part of #9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (#13229)" (#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.

Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>

* pending with tests

* added event

* added respective tests

Co-authored-by: Srijan Reddy <srijan@srijanreddy.com>
Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>
Rijuta-s pushed a commit that referenced this pull request Jan 12, 2022
@sahiljoster32 @srijanreddy98
Fixes practice tab's start button behaviour (#14583)
ae587d1 
* Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)

* Revert "Revert "Fix part of #9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (#13229)" (#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.

Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>

* fixed

* fixed -1

* apply requested changes -2

* added I18n keys

* fixed lint

Co-authored-by: Srijan Reddy <srijan@srijanreddy.com>
Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>
srijanreddy98 pushed a commit that referenced this pull request Jan 13, 2022
@anurag629
Fix part of #13956: Replaced python_utils.ZIP() with zip() (#14279)
f35a663 
* all python_utils.ZIP changed with ZIP

* changed python_utils.ZIP to zip

* check failed again corrected

* moved to previous line

* moved all to previous line

* Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)

* Revert "Revert "Fix part of #9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (#13229)" (#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.

* removed all python_utils unused imports

* removed all unused python_utils imports

* line too long lint checks corrected

* resolved comment by dubey sandeep

* fix

Co-authored-by: ANURAG VERMA <20cse08@ietagra.org.in>
Rijuta-s pushed a commit that referenced this pull request Jan 19, 2022
@sahiljoster32 @Lawful2002
@srijanreddy98 @gp201
Implemented new UI changes in lessons page (mobile view). (#14512)
cd721ef 
* initial ui changes

* changed classroom to learn (en)

* some more changes

* added multi-language support for learn tab

* made navbar contents dynamic

* added test for classroom data

* minor changes

* added webp image and minor changes

* changes

* corrected variable names and some ui changes

* [skip ci] made dropdown smaller to fix issue with certain languages

* [skip ci] made dropdown smaller to fix issue with certain languages

* Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)

* Revert "Revert "Fix part of #9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (#13229)" (#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.

Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>

* added dynamic shifting for nav dropdown

* [skip ci] added a frontend test for getDropdownOffset

* fixed some console errors

* [skip ci] corrected alphabetical order

* corrected call to classroomBackendAPI

* fixed ui bugs

* moved fetch classroom data function from ngOnInit to ngAfterViewChecked

* added description for the new function

* removed unnecessary api calls

* added keyboard navigation

* fixed a bug where multiple calls were being made

* fixed a bug where multiple calls were being made

* fixed tests

* fixed a minor test issue

* fixed faulty links

* Update core/templates/components/common-layout-directives/navigation-bars/side-navigation-bar.component.spec.ts

Co-authored-by: Praneeth <praneethg2001@gmail.com>

* fixed tests

* added ui

* added tests

* progress bar updated

* lint -1

* added requested changes -1

* minor lint

* updated

* added changes

Co-authored-by: Lawful2002 <sharshvardhan101@gmail.com>
Co-authored-by: Harshvardhan Singh <73544247+Lawful2002@users.noreply.github.com>
Co-authored-by: Srijan Reddy <srijan@srijanreddy.com>
Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>
Co-authored-by: Praneeth <praneethg2001@gmail.com>
Rijuta-s pushed a commit that referenced this pull request Jan 27, 2022
@sahiljoster32 @srijanreddy98
Fixes creator dashboard button's screen position, added hover effect …
738f2b7 
…on main menu and removed extra unit spaces. (#14721)

* Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)

* Revert "Revert "Fix part of #9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (#13229)" (#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.

Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>

* fixed hover issue

* fixed create button

* fixes unit spaces

* fixed unit spaces

Co-authored-by: Srijan Reddy <srijan@srijanreddy.com>
Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>
Rijuta-s pushed a commit that referenced this pull request Jan 28, 2022
@sahiljoster32 @srijanreddy98
Added new empty lessons tab and fixes feedback tab's title position. (#…
e31e99c 
…14768)

* Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)

* Revert "Revert "Fix part of #9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (#13229)" (#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.

Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>

* added learn something new component

* fixed

* completed

* fixed feedback card

* added changes

* nits

Co-authored-by: Srijan Reddy <srijan@srijanreddy.com>
Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>
nithusha21 pushed a commit that referenced this pull request Feb 7, 2022
@sahiljoster32 @srijanreddy98
Minor UI changes in side-navbar. (#14836)
b58cd35 
* Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)

* Revert "Revert "Fix part of #9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (#13229)" (#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.

Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>

* added minor ui changes

Co-authored-by: Srijan Reddy <srijan@srijanreddy.com>
Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>
nithusha21 pushed a commit that referenced this pull request Feb 9, 2022
@sahiljoster32 @srijanreddy98
Fixes The order of In-progress lessons. (#14868)
68e4612 
* Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)

* Revert "Revert "Fix part of #9749: Create a component that shows rte-output-display and use it instead of angular-html-bind. (#13229)" (#13361)"

This reverts commit 792de45.

* Fix issues

* Fix spelling mistakes in comment

* Merge with upstream/develop

* Address review comments:
  1. Move oppia-rte-output.spec from the list of ignored files for innerHTML check in eslintrc and move to inline disables.
  2. Change the CODEOWNER listing from oppia-rte-parser.service.ts to oppia-rte-parser.service*.ts to include the spec file.
  3. Add refernce to the note at the top of file for all value.replace ops.
  4. Miscellaneous changes.

Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>

* fixed ordering

* fixed temp variable

Co-authored-by: Srijan Reddy <srijan@srijanreddy.com>
Co-authored-by: Vasa Srijan Reddy <redvasa@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamprayush iamprayush iamprayush requested changes

@Hudda Hudda Hudda approved these changes

@ashutoshc8101 ashutoshc8101 ashutoshc8101 approved these changes

@aks681 aks681 aks681 approved these changes

@EricZLou EricZLou EricZLou approved these changes

@U8NWXD U8NWXD U8NWXD approved these changes

@DubeySandeep DubeySandeep DubeySandeep approved these changes

@nithusha21 nithusha21 nithusha21 approved these changes

@kevintab95 kevintab95 kevintab95 approved these changes

@vojtechjelinek vojtechjelinek vojtechjelinek approved these changes

Assignees

@kevintab95 kevintab95

@srijanreddy98 srijanreddy98

@iamprayush iamprayush

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTE components disappear after exploration preview