Thanks, @GraceGSy!

@amitdeutsch, do you have any thoughts on these?

Hi @GraceGSy, I've taken another look and thought about this a bit more. Here's what I would suggest, though some of these changes are a bit more technical and can, I think, be left to a future commit:

• I think the icons should be grayscale, following the others on the left. I'm looking at examples like the email compose editor in gmail, and the textAngular home page, and all of them make no color distinction between B/I/U and things like insert image/link.
• It's getting a bit unwieldy to store the images as data strings, and I'm not entirely sure this is necessary. I'm going to try doing a PR that removes this, and will send that to you for review.

The last suggestion I have (probably for a separate PR) is to organize the components so that the more common ones (link, image, video) are on the left, and the less common ones (collapsible, tabs, math) are on the right. Would you agree with this -- and, if so, what do you think would be a good order? It's a bit more involved, code-wise, so I think this can be done in a separate pass.

Thanks!

Hi all,

Thanks for working on this, Grace! A few issues I see:

First, regarding the color: I agree that at the icons should all be the same color, like Sean mentioned.

Second, the blue icons on the right are rather blurry compared to the crisp icons on the left:

I would recommend doing vectors instead of bitmap images, they'll look much better.

Finally, the images used for the icons still have white backgrounds; note that there is a white bounding box around the icon that's being hovered over here:

Whether using bitmap or vector graphics, they shouldn't have these white backgrounds.

Thanks again for your work on this,
Amit

New icons have been pushed!

The hints icon is above for future use.

Current coverage is 43.75%

Merging #1401 into develop will decrease coverage by -0.09% as of 001227b

@@            develop   #1401   diff @@
=======================================
  Files           180     181     +1
  Stmts         14863   14902    +39
  Branches       2386    2392     +6
  Methods           0       0       
=======================================
+ Hit            6516    6521     +5
- Partial         578     584     +6
- Missed         7769    7797    +28

Review entire Coverage Diff as of 001227b

Powered by Codecov. Updated on successful CI builds.

Thanks so much, @GraceGSy -- this looks great! Merging into develop.