Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pip package beam #13938

Merged
merged 49 commits into from
Oct 1, 2021
Merged

Pip package beam #13938

merged 49 commits into from
Oct 1, 2021

Conversation

vojtechjelinek
Copy link
Contributor

Overview

  1. This PR fixes or fixes part of #[fill_in_number_here].
  2. This PR does the following: [Explain here what your PR does and why]

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Oppiabot can assign anyone for review/help if you leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL"
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

brianrodri and others added 25 commits September 16, 2021 21:35
@brianrodri
move jobs/ into core/
a9c9060
@brianrodri
update jobs packages
0d83947
@brianrodri
Merge branch 'develop' into pip-package-oppia
d238d72
@brianrodri
update jobs packages remnants
bb2ba98
@brianrodri
fix linter
04593da
@brianrodri
fix imports
5743a85
@brianrodri
add setup.py
0446dfe
@brianrodri
Merge remote-tracking branch 'upstream/develop' into pip-package-oppia
f0c90ee
@brianrodri
Merge remote-tracking branch 'upstream/develop' into pip-package-oppia
898275b
@brianrodri
add encoding to open()
2238856
@brianrodri
fix lint
a2dae21
@brianrodri
move feconf
0d0f018
@brianrodri
Merge remote-tracking branch 'upstream/develop' into pip-package-oppia
f62860b
@brianrodri
fix FECONF_PATH
c694469
@brianrodri
fix test
9eb6d34
@brianrodri
move utils
aaa5fb4
@brianrodri
move python_utils
fbdea4a
@brianrodri
fix linter test
c3b492c
@brianrodri
fix python_utils test
cdfd4a6
@brianrodri
remove temp_file.txt
a01da65
@brianrodri
fix linter test
76ffe65
@brianrodri
move schema_utils
24647d5
@brianrodri
move constants
158a51b
@brianrodri
move android_validation_constants
aa2e415
@vojtechjelinek
Merge branch 'pip-package-oppia' of https://github.com/brianrodri/oppia…
342ef7f 
… into pip-package-beam
@oppiabot
Copy link

oppiabot bot commented Sep 27, 2021

Hi @vojtechjelinek, can you complete the following:

  1. The body of this PR is missing the required description, please update the body with a description of what this PR does.
  2. The karma and linter checklist has not been checked, please make sure to run the frontend tests and lint tests before pushing.
  3. The proof that changes are correct has not been provided, please make sure to upload a image/video showing that the changes are correct. Or include a sentence saying "No proof of changes needed because" and the reason why proof of changes cannot be provided.
    Thanks!

@oppiabot
Copy link

oppiabot bot commented Sep 27, 2021

Hi, @vojtechjelinek, this pull request does not have a "CHANGELOG: ..." label as mentioned in the PR pointers. Assigning @vojtechjelinek to add the required label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@oppiabot
Copy link

oppiabot bot commented Sep 27, 2021

Hi @vojtechjelinek, when creating WIP/Draft PRs, ensure that your commit messages are prefixed with [ci skip] or [skip ci] to prevent CI checks from running. You can learn more about it here.

@oppiabot
Copy link

oppiabot bot commented Sep 27, 2021

Hi @vojtechjelinek, PTAL at this PR, it adds a new cron job.
Also @vojtechjelinek It seems you have added or edited a CRON job, if so please request a testing of this CRON job with this server jobs form Please refer to this guide for details.
Thanks!

This was referenced Oct 1, 2021
Closed
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlip seanlip seanlip approved these changes

@brianrodri brianrodri brianrodri approved these changes

@aks681 aks681 Awaiting requested review from aks681

@BenHenning BenHenning Awaiting requested review from BenHenning

@darksun27 darksun27 Awaiting requested review from darksun27

@DubeySandeep DubeySandeep Awaiting requested review from DubeySandeep

@hardikkat24 hardikkat24 Awaiting requested review from hardikkat24

@Hudda Hudda Awaiting requested review from Hudda

@iamprayush iamprayush Awaiting requested review from iamprayush

@nithusha21 nithusha21 Awaiting requested review from nithusha21

@sajalasati sajalasati Awaiting requested review from sajalasati

@srijanreddy98 srijanreddy98 Awaiting requested review from srijanreddy98

@vinitamurthi vinitamurthi Awaiting requested review from vinitamurthi

@SAEb-ai SAEb-ai Awaiting requested review from SAEb-ai

@sagangwee sagangwee Awaiting requested review from sagangwee sagangwee is a code owner automatically assigned from oppia/contributor-experience-team

Assignees

@vojtechjelinek vojtechjelinek

@nithusha21 nithusha21

@BenHenning BenHenning

@DubeySandeep DubeySandeep

@aks681 aks681

@Hudda Hudda

@darksun27 darksun27

@iamprayush iamprayush

@hardikkat24 hardikkat24

@SAEb-ai SAEb-ai

Labels
PR: Affects datastore layer Labels to indicate a PR that changes the datastore layer. PR: require post-merge sync to HEAD Require all open pull requests to be updated after this PR get's merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.