Unit test for exploration creation service #13176

aishwary023 · 2021-06-22T12:47:38Z

Overview

This PR fixes or fixes part of #[fill_in_number_here].
This PR does the following: Covers exploration-creation.service.ts

Essential Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The linter/Karma presubmit checks have passed locally on your machine.
"Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
- This lets reviewers restart your CircleCI tests for you.
The PR is made from a branch that's not called "develop".

Proof that changes are correct

PR Pointers

Make sure to follow the instructions for making a code change.
Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
For what code owners will expect, see the Code Owner's wiki page.
Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
Never force push. If you do, your PR will be closed.
Oppiabot can assign anyone for review/help if you leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL"
Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

Radesh-kumar · 2021-06-22T16:08:07Z

core/templates/components/entity-creation-services/exploration-creation.service.spec.ts

+    expect(windowRef.nativeWindow.location.href).toBe('/create/expId');
+  }));
+
+  it('should show upload exploration modal', fakeAsync(() => {


Description is unclear.
can we have this pattern should do X if Y happens?

Radesh-kumar · 2021-06-22T16:09:54Z

core/templates/components/entity-creation-services/exploration-creation.service.spec.ts

+    expect(loaderService.hideLoadingScreen).toHaveBeenCalled();
+  }));
+
+  it('should show upload exploration modal', fakeAsync(() => {


Why do have we two tests with the same description?
(Ref: line no. 209)

Radesh-kumar · 2021-06-22T16:10:52Z

core/templates/components/entity-creation-services/exploration-creation.service.spec.ts

+    expect(ecbas.registerNewExplorationAsync).toHaveBeenCalled();
+  });
+
+  it('should create new exploration', fakeAsync(() => {


Why do we have similar tests here?
(Ref line no. 146)

Radesh-kumar

LGTM!

oppiabot · 2021-06-23T11:16:14Z

Unassigning @Radesh-kumar since they have already approved the PR.

DubeySandeep

@aishwary023 Thanks for the PR, I've left a few comments, PTAL!

core/templates/components/entity-creation-services/exploration-creation.service.spec.ts

DubeySandeep · 2021-06-24T20:56:32Z

core/templates/components/entity-creation-services/exploration-creation.service.spec.ts

+        if (this.throwError) {
+          errorCallback(this.message);
+        } else {
+          successCallback({
+            explorationId: 'exp1'


Avoid adding logics in test files*

This was to trigger the failure callback, which I don't think we can omit

is this resolved?

Yes, removed the mock and the logic as well

DubeySandeep · 2021-06-24T20:57:45Z

core/templates/components/entity-creation-services/exploration-creation.service.spec.ts

+
+    ecs = TestBed.inject(ExplorationCreationService);
+    ecbas = (TestBed.inject(
+      ExplorationCreationBackendApiService) as unknown) as


Why as unkown?

Not using as unknown gives this error:

Conversion of type 'ExplorationCreationBackendApiService' to type 'MockExploratinoCreationBackendApiService' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

Are we still using the MockService?

Nope, removed the mock

DubeySandeep · 2021-06-24T20:58:51Z

core/templates/components/entity-creation-services/exploration-creation.service.spec.ts

+
+  it('should not create a new exploration if another exploration' +
+    ' creation is in progress', () => {
+    spyOn(ecbas, 'registerNewExplorationAsync');


Do we have mock class + spyOn togther? Just having spyOn would be better, right?

Explained in a comment below

core/templates/components/entity-creation-services/exploration-creation.service.spec.ts

oppiabot · 2021-07-02T11:29:16Z

Hi @aishwary023, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

aishwary023 · 2021-07-03T01:22:05Z

@DubeySandeep @nithusha21 PTAL, thanks!

DubeySandeep

LGTM for the codeowner file

oppiabot · 2021-07-03T22:40:34Z

Unassigning @DubeySandeep since they have already approved the PR.

oppiabot · 2021-07-05T17:46:53Z

Unassigning @nithusha21 since they have already approved the PR.

oppiabot · 2021-07-05T17:46:57Z

Hi @aishwary023, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

oppiabot · 2021-07-05T18:07:50Z

Hi @aishwary023, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

commit 1daef35 Author: Brian Rodriguez <brian@brianrodri.com> Date: Wed Jul 7 23:37:43 2021 -0400 fix lint commit c45ac4e Merge: 76360a5 aae335d Author: Brian Rodriguez <brian@brianrodri.com> Date: Wed Jul 7 23:25:52 2021 -0400 Merge branch 'fix-pylint' into index-all-activities commit aae335d Author: Brian Rodriguez <brian@brianrodri.com> Date: Wed Jul 7 23:20:26 2021 -0400 Fix part of oppia#12718: Use init-hook to fix command line calls to pylint commit 76360a5 Author: Brian Rodriguez <brian@brianrodri.com> Date: Wed Jul 7 23:03:22 2021 -0400 replace index-all-activities-job commit 1cb69a8 Author: Praneeth <praneethg2001@gmail.com> Date: Thu Jul 8 04:09:09 2021 +0530 Fixes Typescript issue in oppia-short-response-mulitple-choice-input.component and mypy issue in schema_utils.py (oppia#13335) * minor fixes * mypy fix commit e2e59bd Author: Praneeth <praneethg2001@gmail.com> Date: Thu Jul 8 00:04:55 2021 +0530 Frontend Unit Tests(3): Cover multiple component files (oppia#13303) * intial commit * minor fix commit 186435d Author: Hardik Katehara <54679643+hardikkat24@users.noreply.github.com> Date: Wed Jul 7 22:44:02 2021 +0530 Fix oppia#13239 and oppia#13171: Adding type annotations to root files and fix constants errors with mypy (oppia#13269) commit 7f5757f Author: EeshaArif <43031234+EeshaArif@users.noreply.github.com> Date: Wed Jul 7 22:13:10 2021 +0500 Fix Part of oppia#10474: Cover some files with TS strict checks - 6 (oppia#13263) commit 1577479 Author: Nikhil <57531197+Nik-09@users.noreply.github.com> Date: Wed Jul 7 21:21:14 2021 +0530 Adds schema for handlers concept_card_viewer & contributor_dashboard modules (oppia#13225) * payload_validator(created) + schema_utils(modified) for SVS architecture * payload * validate_args_schema in base + backend tests * Adds linters to verify handlers must have schema * Shows exception message in frontend when SVS validation fails. * adds schema in backend test * fix coverage * adds backend test for payload_validator into shard 1. * Changes logic for handling default_value cases. * removes dict from properties list in schema utils * fix coverage * changes codeowners * Adds backend unit tests + comments + docstrings * fix coverage * adds backend tests for coverage * fix coverage * adds backend tests for coverage * fix coverage * fix coverage * adds test into shard * backend coverage * fix coverage * structured backend test. * adds docstring * fix coverage * changes formatting for schema in MockHandlers * refactor domain objects validator * refactor handling object_dict * fixes backend tests. * validate_method -> validation_method * adds extra checks in backend test. * updates comment * adds backend tests. * Addressed review comments. * fix coverage * Addressed review comments. * fixes backend tests for linters * Addressed review comments. * updates loop into list comprehension. * addressed review comments * fix coverage * addressed review comments. * addressed review comments * addressed review comments. * fix coverage * addressed review comments * fix coverage * remove repeted code. * addressed review comments. * removes duplicate code from payload_validator * fix backend tests * schemas for contributor_dashboard+concept_card_viewer * fixes backend tests * updates logic for handling optional cases * fixes backend tests * adds backend coverage tests * refactores payload validator * adds schema type string * adds handler class name in old handlers list * fixes backend tests * fix coverage * removes dead code. * makes backend code typed. * adds new handler class in old handler * addressed review comments * fix coverage * fix coverage * updates logic for handling normalized value * changes string -> basestring * updates schema. * updates schemas * addressed review comments * updates by adding schema key 'schema' * adds validator for language code. * fix coverage * adds comment and updates docstring. * udates comment. * updates comment * updates comment * updates comment * updates schemas * changes docstring. * updates logic to handle csrf and source * fixes backend tests * updates logic to raise 400 * updates logic to handle source * updates logic * removes if-block in dispatch method * adds previous if-else logic to handle source * updates if into elif * adds comment in csrf_token * updates logic and adds tests for backend coverage. * fixes coverage * updates comment * uses sanitize url instead of regex. * fix coverage * fix coverage. * uses regex to check source url. commit f9a5144 Author: Ashutosh Chauhan <ashutoshc8101@gmail.com> Date: Wed Jul 7 16:10:51 2021 +0530 Fix part of oppia#9749: Migrate Preferences page (oppia#13219) commit 6b1f473 Author: Brian Rodriguez <brian@brianrodri.com> Date: Wed Jul 7 00:31:34 2021 -0400 Fix part of oppia#11475: Delete all references to continuous jobs (oppia#13313) * Removed notification page * Fixed merge conflict file * Fixed ts error * Removed notification from accessiblity test * Fixed JS lint issue * Changed the shortcut for preferenceURL * additional nits * Fixed ts error * reverting removal of userbackend service * Added back the changes * Delete FeedbackAnalyticsAggregator * fix unused code * add PR to note * small nit * address comments * initial attempt * initial attempt * fix ratings test * delete file * reduce untested lines * fix lint * remove frontend references to continuous jobs * remove backend references to continuous jobs * remove checks for events * fix lint * delete QUEUE_NAME_EVENTS * delete events from queue.yaml * fix bugs * fix queue.yaml tests * fix coverage * fix lint Co-authored-by: Aasif Faizal <aasif.faizal@gmail.com> commit 4c64eee Author: Rijuta Singh <68547101+Rijuta-s@users.noreply.github.com> Date: Wed Jul 7 06:47:32 2021 +0530 Milestone 1.5 : Adds blog admin page frontend. (oppia#13300) * Adding blog admin page * adding blog admin page * fixing lint * minor fixes * [ci skip] adding spec file * adding spec file * applying suggestions * applying suggestions * Applting lint suggestions * applying suggestions * fixing lint issues * sdcsd * applying suggestions * Revert adding root component files This reverts commit 6bd0d76. * applying suggestions * minor fix commit a2f9d14 Author: Aishwary Saxena <aishwary.saxena.min19@itbhu.ac.in> Date: Tue Jul 6 18:09:15 2021 +0530 Unit test for questions-list.component.ts (oppia#13287) * Converted AJS Directive to AJS Component * Added tests * Added tests, completed 100% * Fixed lint checks * fix karma conf * Addressed review commit 79e6d10 Author: Aishwary Saxena <aishwary.saxena.min19@itbhu.ac.in> Date: Tue Jul 6 14:49:00 2021 +0530 Unit test for exploration creation service (oppia#13176) * Added tests * Lint err * Added callback for dataFilter * Removed file name from NOT_FULLY_COVERED_FILENAMES * Added expectations * Nit * Nit * Addressed review * Removed fdescribe * Addressed review * lint * Removed mock * Fix * removed fdescribe commit e0a39a2 Author: Farees Hussain <fareezzhussain@gmail.com> Date: Tue Jul 6 13:14:13 2021 +0530 Fix oppia#13172: Controller to initialize android specific structures (Milestone 1.2) (oppia#13174) * controller to initiate android specific structures * fix linters * using variable for exploration id * fix linters * upload thumbnails * added tests * fix linters * remove csrf token * added to shards * refactoring and testcases * fix CI checks * fix CI * Addressed requested changes * rename test * timeout 30 with comment * fix linter * remove post_req * added render_json * NIT * changed comment * whitespace * requested changes * more docs * NIT * docstring update * addressed suggestions * replaced 500 with 400 * update docstring * updated docstring commit d12bfc1 Author: Kevin Thomas <kevintab@tutanota.com> Date: Tue Jul 6 12:08:19 2021 +0530 Fix typescript check failure (oppia#13321) commit c037e83 Author: Kevin Thomas <kevintab@tutanota.com> Date: Tue Jul 6 11:33:46 2021 +0530 Modify translation submission validation to check for custom tags (oppia#13309) commit 220c03a Author: Radesh <54100702+Radesh-kumar@users.noreply.github.com> Date: Tue Jul 6 10:42:21 2021 +0530 Added unit tests for admin roles tab (oppia#13206) commit 56a9e43 Author: Kevin Thomas <kevintab@tutanota.com> Date: Tue Jul 6 09:57:02 2021 +0530 Add Marathi (मराठी) and Ganda (Luganda) to supported languages (oppia#13315) commit c82945e Author: AdityaDubey0 <55298925+AdityaDubey0@users.noreply.github.com> Date: Tue Jul 6 03:53:03 2021 +0530 Migrate lint check to disallow innerHTML property. (oppia#13301) commit 901bc8b Author: Hitesh Tomar <44300735+lkbhitesh07@users.noreply.github.com> Date: Tue Jul 6 02:33:38 2021 +0530 warning text is within the box (oppia#13296) commit 90d0152 Author: AdityaDubey0 <55298925+AdityaDubey0@users.noreply.github.com> Date: Tue Jul 6 01:45:41 2021 +0530 Disallow $parent and $broadcast angularJs property (oppia#13291)

aishwary023 added 5 commits June 22, 2021 09:13

Added tests

1230ccb

Lint err

ab36b8a

Merge remote-tracking branch 'upstream/develop' into exp-creation

1aa2e56

Added callback for dataFilter

931ce44

Removed file name from NOT_FULLY_COVERED_FILENAMES

74c6e0f

aishwary023 added the PR CHANGELOG: Automated QA Team -- @U8NWXD label Jun 22, 2021

aishwary023 self-assigned this Jun 22, 2021

aishwary023 requested review from DubeySandeep, kevintab95 and nithusha21 as code owners June 22, 2021 12:47

aishwary023 added 3 commits June 22, 2021 18:44

Added expectations

ead87f9

Nit

a972652

Nit

ff02b38

Radesh-kumar suggested changes Jun 22, 2021

View reviewed changes

aishwary023 added 3 commits June 23, 2021 08:27

Merge remote-tracking branch 'upstream/develop' into exp-creation

00545ed

Addressed review

bb2c627

Removed fdescribe

e29f2a6

aishwary023 assigned Radesh-kumar, kevintab95, nithusha21 and DubeySandeep and unassigned aishwary023 and Radesh-kumar Jun 23, 2021

Radesh-kumar approved these changes Jun 23, 2021

View reviewed changes

oppiabot bot unassigned Radesh-kumar Jun 23, 2021

DubeySandeep requested changes Jun 24, 2021

View reviewed changes

oppiabot bot unassigned DubeySandeep Jun 24, 2021

srijanreddy98 removed their assignment Jul 1, 2021

oppiabot bot added the PR: don't merge - STALE BUILD label Jul 2, 2021

nithusha21 removed their assignment Jul 2, 2021

aishwary023 added 4 commits July 3, 2021 05:37

Merge remote-tracking branch 'upstream/develop' into exp-creation

b0a4b04

Removed mock

c676ea0

Fix

d11b2c1

removed fdescribe

81b8e0a

oppiabot bot removed the PR: don't merge - STALE BUILD label Jul 3, 2021

oppiabot bot assigned nithusha21 Jul 3, 2021

Merge remote-tracking branch 'upstream/develop' into exp-creation

0f14676

DubeySandeep approved these changes Jul 3, 2021

View reviewed changes

oppiabot bot unassigned DubeySandeep Jul 3, 2021

nithusha21 approved these changes Jul 5, 2021

View reviewed changes

oppiabot bot unassigned nithusha21 Jul 5, 2021

oppiabot bot added the PR: LGTM label Jul 5, 2021

oppiabot bot assigned aishwary023 Jul 5, 2021

oppiabot bot added the PR: don't merge - STALE BUILD label Jul 5, 2021

aishwary023 added 3 commits July 5, 2021 23:56

Merge remote-tracking branch 'upstream/develop' into exp-creation

c279c72

Merge remote-tracking branch 'upstream/develop' into exp-creation

57f5ed6

Merge remote-tracking branch 'upstream/develop' into exp-creation

23e7a4f

oppiabot bot removed the PR: don't merge - STALE BUILD label Jul 6, 2021

aishwary023 enabled auto-merge (squash) July 6, 2021 07:09

aishwary023 merged commit 79e6d10 into oppia:develop Jul 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unit test for exploration creation service #13176

Unit test for exploration creation service #13176

aishwary023 commented Jun 22, 2021

Radesh-kumar Jun 22, 2021

aishwary023 Jun 23, 2021

Radesh-kumar Jun 22, 2021 •

edited

Loading

aishwary023 Jun 23, 2021

Radesh-kumar Jun 22, 2021 •

edited

Loading

aishwary023 Jun 23, 2021

Radesh-kumar left a comment

oppiabot bot commented Jun 23, 2021

DubeySandeep left a comment

DubeySandeep Jun 24, 2021

aishwary023 Jun 26, 2021

DubeySandeep Jul 3, 2021

aishwary023 Jul 3, 2021

DubeySandeep Jun 24, 2021

aishwary023 Jun 26, 2021

DubeySandeep Jul 3, 2021

aishwary023 Jul 3, 2021

DubeySandeep Jun 24, 2021

aishwary023 Jun 26, 2021

oppiabot bot commented Jul 2, 2021

aishwary023 commented Jul 3, 2021

DubeySandeep left a comment

oppiabot bot commented Jul 3, 2021

oppiabot bot commented Jul 5, 2021

oppiabot bot commented Jul 5, 2021

oppiabot bot commented Jul 5, 2021

Unit test for exploration creation service #13176

Unit test for exploration creation service #13176

Conversation

aishwary023 commented Jun 22, 2021

Overview

Essential Checklist

Proof that changes are correct

PR Pointers

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Radesh-kumar Jun 22, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Radesh-kumar Jun 22, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Radesh-kumar left a comment

Choose a reason for hiding this comment

oppiabot bot commented Jun 23, 2021

DubeySandeep left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oppiabot bot commented Jul 2, 2021

aishwary023 commented Jul 3, 2021

DubeySandeep left a comment

Choose a reason for hiding this comment

oppiabot bot commented Jul 3, 2021

oppiabot bot commented Jul 5, 2021

oppiabot bot commented Jul 5, 2021

oppiabot bot commented Jul 5, 2021

Radesh-kumar Jun 22, 2021 •

edited

Loading

Radesh-kumar Jun 22, 2021 •

edited

Loading