Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds flaky e2e report and restart functionality #11263

Merged
merged 31 commits into from
Dec 19, 2020
Merged

Adds flaky e2e report and restart functionality #11263

merged 31 commits into from
Dec 19, 2020

Conversation

DubeySandeep
Copy link
Member

@DubeySandeep DubeySandeep commented Nov 25, 2020 •
edited
Loading

Overview

This PR does the following: Removes the old structure to auto-restart flaky test as it wasn't working on CIs. Through this PR the script will send the output lines to a Heroku server, and the server return whether the test is flaky or not.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.

@oppiabot
Copy link

oppiabot bot commented Nov 25, 2020

Hi, @DubeySandeep, this pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Assigning @ DubeySandeep to add the required label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@DubeySandeep DubeySandeep mentioned this pull request Nov 26, 2020
Closed
4 tasks
@DubeySandeep
Copy link
Member Author

Assigned @kevintab95 to this PR for reference as he is also working on the same file and related to similar functionality.
[@kevintab95 either we can get this PR merged quickly or you can create a separate PR to restart the test 3 times following the same structure so that I have fewer and simpler merge conflicts.]

U8NWXD
U8NWXD requested changes Nov 30, 2020
View reviewed changes
scripts/run_e2e_tests.py Outdated Show resolved Hide resolved
scripts/run_e2e_tests.py Outdated Show resolved Hide resolved
scripts/run_e2e_tests.py Outdated Show resolved Hide resolved
scripts/flake_checker.py Outdated Show resolved Hide resolved
scripts/flake_checker.py Outdated Show resolved Hide resolved
scripts/flake_checker.py Outdated Show resolved Hide resolved
scripts/flake_checker.py Outdated Show resolved Hide resolved
scripts/flake_checker.py Outdated Show resolved Hide resolved
scripts/flake_checker.py Outdated Show resolved Hide resolved
scripts/flake_checker.py Outdated Show resolved Hide resolved
@vojtechjelinek vojtechjelinek changed the title Adds flaky e2e report and restart functionlaity Adds flaky e2e report and restart functionality Nov 30, 2020
vojtechjelinek
vojtechjelinek approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vojtechjelinek vojtechjelinek removed their assignment Nov 30, 2020
@oppiabot
Copy link

oppiabot bot commented Nov 30, 2020

Hi @DubeySandeep. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@kevintab95 kevintab95 mentioned this pull request Nov 30, 2020
Merged
4 tasks
nithusha21
nithusha21 approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a codeowner. Thanks Chris for the thorough review!

@oppiabot
Copy link

oppiabot bot commented Dec 13, 2020

Hi @DubeySandeep, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop, Thanks.

@oppiabot
Copy link

oppiabot bot commented Dec 14, 2020

Hi @DubeySandeep. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@U8NWXD U8NWXD removed their assignment Dec 19, 2020
@oppiabot oppiabot bot added the PR: LGTM label Dec 19, 2020
@oppiabot
Copy link

oppiabot bot commented Dec 19, 2020

Hi @DubeySandeep, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

kevintab95
kevintab95 approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@kevintab95 kevintab95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @U8NWXD!

@U8NWXD U8NWXD merged commit fefa6c8 into oppia:develop Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@U8NWXD U8NWXD U8NWXD approved these changes

@nithusha21 nithusha21 nithusha21 approved these changes

@kevintab95 kevintab95 kevintab95 approved these changes

@vojtechjelinek vojtechjelinek vojtechjelinek approved these changes

Assignees

@DubeySandeep DubeySandeep

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DubeySandeep @U8NWXD @vojtechjelinek @kevintab95 @nithusha21