Fix #11006: Add google as known third-party library #11018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @U8NWXD, this pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Assigning @U8NWXDto add the required label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks! |
34 tasks
|
@seanlip @DubeySandeep @Hudda PTAL |
4 tasks
U8NWXD
added a commit
to nithusha21/oppia
that referenced
this pull request
Oct 22, 2020
We need to import `google.oauth2` after we import `python_utils` because importing `python_utils` sets `sys.path` as needed for `google.oauth2`. This commit replicates changes from oppia#11018 that fix the linter to recognize google.oauth2 as a third-party library.
|
Unassigning @Hudda since they have already approved the PR. |
DubeySandeep
approved these changes
Oct 22, 2020
There was a problem hiding this comment.
@U8NWXD, Thanks for the PR, I have left one question PTAL! [Approving this PR to unblock the merge as this will fix issue in develop branch!]
|
Unassigning @DubeySandeep since they have already approved the PR. |
|
@seanlip PTAL. This issue is blocking new contributors |
seanlip
pushed a commit
that referenced
this pull request
Oct 28, 2020
* add automatic restarts for flakes, and automatic logging in sheets * use service accounts instead of API keys, and download the credentials * some lint fixes * add encryption, and fix conditions for checking for flakes * add python dependencies * add more pip dependencies * fix lint issues * fix more lint issues * fix more lint issues * reorder codeowner files * fix import issues, and add missing lib to installation * exclude encrypted file from linting * Fix backend tests * Move installation to oppia-tools * fix all lint issues, and import issues * fix lint issues * Add simple crpyt to path * add google-api-client to path * add missing library * add pkg_resources * remove changes from linter * trying to debug env on CI * more debugging * more debugging * fix config * fix indent * Fix lint errors * Fix imports for linter * change installation * fix linter * Remove Google Import Code from Linter becbbcf changed the way imports are handled, so we don't need the special path-modifying code in the linter script anymore. * Write backend tests for run_e2e_tests functions * Fix lint errors * fix linting issues * Fix backend test coverage * fix lint issue * remove unnecessary change * fix lint problems * fix lint problems * fix import issue * Fix lint errors * Fix Import Order We need to import `google.oauth2` after we import `python_utils` because importing `python_utils` sets `sys.path` as needed for `google.oauth2`. This commit replicates changes from #11018 that fix the linter to recognize google.oauth2 as a third-party library. * Resolve some comments Co-authored-by: nithusha21 <nithusha21@yahoo.co.in> Co-authored-by: DubeySandeep <dubeysandeep.in@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Essential Checklist
PR Pointers