Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status of feedback thread not displayed on learner dashboard. #7161

Closed
YashJipkate opened this issue Jul 17, 2019 · 2 comments · Fixed by #7183
Closed

Status of feedback thread not displayed on learner dashboard. #7161

YashJipkate opened this issue Jul 17, 2019 · 2 comments · Fixed by #7183
Assignees
@DubeySandeep
Labels
frontend

Comments

@YashJipkate
Copy link
Contributor

Describe the bug
The learner dashboard does not show the status of the feedback thread.

To Reproduce

  1. Login to oppia
  2. Create an exploration and publish it.
  3. Login as a different user and navigate to the exploration player page.
  4. Add some feedback for the exploration.
  5. Log in again as the first user, and navigate to the exploration create view.
  6. Send some message to the thread, and edit the status of the thread
  7. By logging in as the second user, the messages are still visible but the status is not displayed.

Observed behavior
Status not visible.

Expected behavior
Status should be visible

Screenshots
The Learner dashboard:
Screenshot from 2019-07-17 22-59-33

The Creator dashboard:
Screenshot from 2019-07-17 23-00-01
@DubeySandeep DubeySandeep added this to the Blocking bugs milestone Jul 17, 2019
@DubeySandeep
Copy link
Member

I was looking into this issue and fixed it but realized that there's a major issue in our translation feature.
image

The expected pattern for translate-values is {key: '<[expression]>'} and we haven't used the quote(') for any values. Also, in some places (like in learner dashboard page), we have used expressions for generating keys which are not required.

Another issue (introduced here): We have used translate-interpolation="$ctrl.messageformat" instead of translate-interpolation="messageformat" and because of this user's cannot see messages in the item-selection interaction.

I think the first issue was introduced in #6907 (not sure!), @YashJipkate will it be possible for you to fix this issue? (need to be tested thoroughly)

Do let me know if you are busy with your project and you don't have enough time, in that case, I'll go ahead and make a PR!

@DubeySandeep
Copy link
Member

Unassigned @YashJipkate and assigning myself. (As per hangout discussion)

@DubeySandeep DubeySandeep mentioned this issue Jul 20, 2019
Merged
8 tasks
DubeySandeep added a commit that referenced this issue Jul 20, 2019
@DubeySandeep
Fix #7161: Removes expression evaluation braces from i18n translation…
bafc5f5 
…-values (#7183)
DubeySandeep added a commit that referenced this issue Jul 23, 2019
@DubeySandeep
Fix #7161: Removes expression evaluation braces from i18n translation…
f22d64f 
…-values (#7183)
@ankita240796 ankita240796 removed this from the Blocking bugs milestone Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DubeySandeep DubeySandeep

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #7161: Removes expression evaluation braces from i18n translation-values DubeySandeep/oppia
3 participants
@ankita240796 @DubeySandeep @YashJipkate