Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint-restricted-globals rule #6799

Closed
ankita240796 opened this issue May 25, 2019 · 0 comments · Fixed by #6923
Closed

Add eslint-restricted-globals rule #6799

ankita240796 opened this issue May 25, 2019 · 0 comments · Fixed by #6923
Assignees
@ankita240796
Labels
code-health

Comments

@ankita240796
Copy link
Contributor

Add eslint-restricted-globals rule to prevent direct usage of globals in codebase.

Ref #6621
@ankita240796 ankita240796 self-assigned this May 25, 2019
@ankita240796 ankita240796 mentioned this issue Jun 14, 2019
Merged
seanlip pushed a commit that referenced this issue Jun 16, 2019
@ankita240796 @seanlip
Fix #6799: Add restricted globals rule to eslint (#6923)
4802241 
* Add no-restricted-globals

* Remove globals

* Fix order of dependencies

* Fix test

* Add linebreaks

* Add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankita240796 ankita240796

Labels
code-health
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #6799: Add restricted globals rule to eslint ankita240796/oppia
2 participants
@vojtechjelinek @ankita240796