Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing R should only prompt for microphone in translation tab. #6777

Closed
mzaman07 opened this issue May 21, 2019 · 0 comments · Fixed by #6898
Closed

Pressing R should only prompt for microphone in translation tab. #6777

mzaman07 opened this issue May 21, 2019 · 0 comments · Fixed by #6898

Comments

@mzaman07
Copy link
Contributor

mzaman07 commented May 21, 2019

Describe the bug
When you create an exploration and reach the translation tab. Once you navigate out of the translation tab to another tab, then press the R button. The microphone access will be prompted by the browser. Found this while fixing #6708, when I was trying to test and refreshing my tab with the keyboard shortcut . Also occurs in develop branch.

To Reproduce
Steps to reproduce the behavior:

  1. Create an exploration and go to 'Translation Tab'
  2. Navigate away from the translation tab to another tab.
  3. Press R
  4. Browser will prompt for microphone access.

Observed behavior
The browser prompts for microphone access.

Expected behavior
You should only be prompted for microphone access on the translation tab.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information; delete this section if the issue does not arise on desktop):

  • OS: Ubuntu
  • Browser: Chrome 74.0.3729.157 64 bit , Firefox 66.0.5 64 bit

Additional context
This only happens when you navigate to translation tab first, and then navigate out. The cause is the usage of document. Solution should use https://docs.angularjs.org/api/ng/directive/ngKeyup to isolate for the translation tab only.

@mzaman07 mzaman07 changed the title Pressing R should not prompt for microphone when you are not in Translation Tab. Pressing R should only prompt for microphone in translation tab. May 21, 2019
@rafalk342 rafalk342 self-assigned this Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants