Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct usage for window.location in SideNavigationBarDirective.ts #6738

Closed
ankita240796 opened this issue May 15, 2019 · 7 comments · Fixed by #7879
Closed

Remove direct usage for window.location in SideNavigationBarDirective.ts #6738

ankita240796 opened this issue May 15, 2019 · 7 comments · Fixed by #7879
Assignees

Comments

@ankita240796
Copy link
Contributor

ankita240796 commented May 15, 2019

Direct usage of window.location should be changed in the file SideNavigationBarDirective.ts here.

Refer the comment here

@muarachmann
Copy link

Hi @ankita240796 can i be assigned to this thanks

@lkcbharath
Copy link

Is this issue still open? If so, can I be assigned to it

@DubeySandeep
Copy link
Member

DubeySandeep commented Oct 3, 2019

Hi @lkcbharath, I think you haven't signed the CLA yet, would you mind following the getting started wiki page first?
Thanks! :)

@xlogix
Copy link
Contributor

xlogix commented Oct 30, 2019

Direct usage of window.location should be changed in the file SideNavigationBarDirective.ts here.

Refer the comment here

The link to the file can be updated. Here is the new link

@xlogix
Copy link
Contributor

xlogix commented Oct 30, 2019

controllerAs: '$ctrl', controller: ['$timeout', '$window', function ($scope, $window) { var ctrl = this; ctrl.currentUrl = $window.location.pathname;

Does this fix this issue?

@DubeySandeep
Copy link
Member

@xlogix, Thanks for the updated link, I've edited the issue thread and replaced the 404 link with a correct permalink.

Re the fix: I would suggest you create a PR and let's discuss it over there! :)

@xlogix
Copy link
Contributor

xlogix commented Oct 30, 2019

I would like to work on this issue. Please assign it to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants