Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test to ensure usage of angular.mock.inject #6678

Closed
ankita240796 opened this issue Apr 29, 2019 · 2 comments · Fixed by #6924
Closed

Add a test to ensure usage of angular.mock.inject #6678

ankita240796 opened this issue Apr 29, 2019 · 2 comments · Fixed by #6924
Assignees
@ankita240796

Comments

@ankita240796
Copy link
Contributor

In test files, inject should be used as angular.mock.inject to maintain a consistent behavior since we use angular.mock.module instead of module. Typescript supports both inject and angular.mock.inject, so we need a custom test to ensure that angular.mock.inject is used instead of inject.
@ankita240796 ankita240796 self-assigned this Apr 29, 2019
@ankita240796 ankita240796 mentioned this issue Apr 29, 2019
Merged
8 tasks
@jacobdavis11
Copy link
Member

@ankita240796 how is this going?

@ankita240796
Copy link
Contributor Author

Hi @jacobdavis11, currently I am working on milestone 1 of my GSoC project. I will be taking this up after the current release. Sorry for the delay.

@ankita240796 ankita240796 mentioned this issue Jun 14, 2019
Merged
seanlip pushed a commit that referenced this issue Jun 16, 2019
@ankita240796 @seanlip
Fix #6678: Add test for ensuring usage of angular.mock.inject (#6924)
86c4824 
* Add test for ensuring usage of angular.mock.inject

* Remove extra code, move pattern to bad patterns

* Rename for js and ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankita240796 ankita240796

Labels
None yet
Projects
Angular 8 Migration Task Force
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #6678: Add test for ensuring usage of angular.mock.inject ankita240796/oppia
3 participants
@nithusha21 @jacobdavis11 @ankita240796