Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add summary of errors for lint checks on Travis #6103

Closed
apb7 opened this issue Jan 14, 2019 · 2 comments · Fixed by #6165
Closed

Add summary of errors for lint checks on Travis #6103

apb7 opened this issue Jan 14, 2019 · 2 comments · Fixed by #6165
Assignees
@lilithxxx

Comments

@apb7
Copy link
Contributor

apb7 commented Jan 14, 2019

The need is to have a summary of errors section at the end of the lint checks on Travis, similar to the one we have for here in scripts/pre_commit_linter.py.
The approach can be similar as well -- using context managers to redirect output from stdout.
@lilithxxx lilithxxx self-assigned this Jan 19, 2019
@lilithxxx
Copy link
Contributor

lilithxxx commented Jan 22, 2019 •
edited
Loading

@apb7 Well, don't we have a summary of errors in Travis as well (as shown in the screenshot)?
a

@apb7
Copy link
Contributor Author

apb7 commented Jan 24, 2019

@lilithxxx, the summary of errors you're referring to is for the python, js, css and html lint checks -- the one linked in the issue thread. The idea here is to have a complete summary of errors for all the lint checks. Thanks!

@lilithxxx lilithxxx mentioned this issue Jan 25, 2019
Merged
6 tasks
@apb7 apb7 closed this as completed in #6165 Feb 7, 2019
apb7 pushed a commit that referenced this issue Feb 7, 2019
@apb7
Fix #6103: Add summary of errors for lint checks on Travis (#6165)
077a103 
* Add summary of of all errors

* Fix error count

* Restored previous file

* use context managers

* Move pre_commit_linter to top

* delete log files

* Add message to summary section

* Print validating statements before summary section

* Remove linting statements from summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lilithxxx lilithxxx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #6103: Add summary of errors for lint checks on Travis lilithxxx/oppia
2 participants
@apb7 @lilithxxx