Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed space when the text is added just below the image #5973

Closed
bansalnitish opened this issue Dec 12, 2018 · 1 comment · Fixed by #5996
Closed

Changed space when the text is added just below the image #5973

bansalnitish opened this issue Dec 12, 2018 · 1 comment · Fixed by #5996
Labels
frontend needs debugging

Comments

@bansalnitish
Copy link
Contributor

Steps to reproduce:

  1. In the editor mode while creating an exploration add a image.
  2. Start writing the text just below the image and click on content.
  3. Click on the content section to edit it again. You'll notice an empty line (or space) is inserted below the image.

Expected Behaviour:
The spacing should remain same before and after the save button is pressed.

Screenshots:

The content before clicking the save button:
testing1

The content after clicking the save button and then entering the editing mode again:
testing2
@mighty-phoenix
Copy link
Contributor

@bansalnitish this is the result of misconfiguration of Ckeditor. I have already fixed the error. Only the tests are supposed to be changed likewise. See #5853 and #5929 .

@bansalnitish bansalnitish mentioned this issue Dec 14, 2018
Closed
6 tasks
@mighty-phoenix mighty-phoenix mentioned this issue Dec 17, 2018
Merged
6 tasks
bansalnitish pushed a commit that referenced this issue Dec 19, 2018
@mighty-phoenix @bansalnitish
Fix #5973: Fixed the changed space when the text is added just below …
05ed54f 
…the image (#5996)

* Fixed

* Correction

* Revert changes in oppia.css

* Final changes

* Final change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend needs debugging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5973: Fixed the changed space when the text is added just below the image mighty-phoenix/oppia
3 participants
@nithusha21 @bansalnitish @mighty-phoenix