Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only lint files changed by the local user and not by foreign commits #5938

Closed
apb7 opened this issue Dec 3, 2018 · 3 comments · Fixed by #6033
Closed

Only lint files changed by the local user and not by foreign commits #5938

apb7 opened this issue Dec 3, 2018 · 3 comments · Fixed by #6033
Assignees
@lilithxxx

Comments

@apb7
Copy link
Contributor

apb7 commented Dec 3, 2018 •
edited
Loading

In order to make the pre-submit checks faster, we should only lint files which have been changed by the local user. Currently, the checks run for merge commits as well, that is, when the user updates his/her local branch with upstream develop.
To fix this issue, changes probably need to be made in scripts/pre_push_hook.py.
(For more details, refer to #5836).
@apb7 apb7 added the devflow label Dec 3, 2018
@DubeySandeep
Copy link
Member

Hi @apb7, is it similar to #5836?

@apb7
Copy link
Contributor Author

apb7 commented Dec 14, 2018

Ah, yes. I'll close #5836 in favor of this and add a link to it in the issue thread. Thanks!

@apb7 apb7 mentioned this issue Dec 14, 2018
Closed
@lilithxxx lilithxxx self-assigned this Dec 22, 2018
@lilithxxx
Copy link
Contributor

I am working on this

@lilithxxx lilithxxx mentioned this issue Dec 27, 2018
Merged
6 tasks
nithusha21 pushed a commit that referenced this issue Jan 3, 2019
@nithusha21
Fix #5938: Lint checks will run only for the files changed by the user (
52a859f 
#6033)

* Test against upstream

* Removed hard-coded upstream

* Only checks with upstream/develop

* Deleted log file

* Added gitpython to third party

* Test1

* Removed remote_sha1

* Removed test print statements

* Curl instead of pip

* Fixed import of git

* Fixed import error

* Install gitpython requirements

* Add gitpython path to system path

* Change order of install

* Changed order

* Add new line

* Add gitpython's requirements path in pre_push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lilithxxx lilithxxx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5938: Lint checks will run only for the files changed by the user lilithxxx/oppia
3 participants
@DubeySandeep @apb7 @lilithxxx