Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run frontend presubmit checks only if frontend code has changed #5885

Closed
EvsChen opened this issue Nov 18, 2018 · 5 comments · Fixed by #5936
Closed

Run frontend presubmit checks only if frontend code has changed #5885

EvsChen opened this issue Nov 18, 2018 · 5 comments · Fixed by #5936
Assignees
@EvsChen

Comments

@EvsChen
Copy link
Contributor

EvsChen commented Nov 18, 2018

Is your feature request related to a problem? Please describe.
Now the local presubmit checks take a long time. It can be made faster by eliminating unnecessary checks.
Describe the solution you'd like
In the file scripts/run_presubmit_checks.sh, use grep to check whether the git show HEAD --name-only contains the front end directory. If true, run the front end test. Else just skip.

Describe alternatives you've considered
Additional context
@EvsChen EvsChen self-assigned this Nov 18, 2018
@jacobdavis11
Copy link
Member

@EvsChen are you still working on this?

@EvsChen
Copy link
Contributor Author

EvsChen commented Dec 1, 2018

Yes, I'm working on this. At first I was waiting to see if anyone has any comments on this so it took some days.

@seanlip
Copy link
Member

seanlip commented Dec 1, 2018 •
edited
Loading

Oh, I didn't realize you were waiting for comments @EvsChen! I think it's fine to just go ahead with it (and, if possible, test empirically to see how much of a difference it makes).

@EvsChen
Copy link
Contributor Author

EvsChen commented Dec 1, 2018

Sure, I'll just go ahead.

@seanlip
Copy link
Member

seanlip commented Dec 1, 2018

Sounds good, thanks!

@EvsChen EvsChen mentioned this issue Dec 2, 2018
Merged
6 tasks
apb7 pushed a commit that referenced this issue Dec 23, 2018
@EvsChen @apb7
Fix #5885 Only run front end test when front end file changed (#5936)
156ff89 
* Only run front end test when front end file changed

* Change comments according to review

* Front end file change test

* Revert "Front end file change test"

This reverts commit c66e86b.

* Compare against the local branch

* Compare with the branch tip on github

* Front end file change test

* Revert "Front end file change test"

This reverts commit e226e40.

* Front end file change test

* Revert "Front end file change test"

This reverts commit d0f8c78.

* Change words
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvsChen EvsChen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5885 Only run front end test when front end file changed EvsChen/oppia
3 participants
@seanlip @jacobdavis11 @EvsChen