Add to python linting to ensure that class arguments are the first element of the arglist #5876
Comments
|
Hey @lokijuhy can I take this issue ? |
|
Yes, go ahead! |
|
Yes assign me this issue ! |
|
I don't think I have the power to assign the issue. @seanlip is assigning an issue a protected action? |
|
ok! By the way, I have to just make a logic in pre_commiit_linter.py or do anything else? |
|
Yes, this probably just involves extending |
|
Can we talk on gitter ? |
|
Or I have to make a checker using AST (asteroid) ? |
|
Hey, I have added a logic and made a PR #5916 ! |
|
@lokijuhy sorry for the late reply! In general when a contributor has merged 2 PRs, we invite them to collaborate on the Oppia repository. At that point, they gain rights to update issue assignments etc. (We used to do it immediately on signup before but that resulted in way too much churn.) @anubhavsinha98 -- as an FYI, in the initial phase (before 2 PRs are merged), it's fine to just claim an issue by making a comment on it. It won't necessarily be held (since sometimes folks say they want to work on an issue and then disappear), but at least other people know you're looking into it, and you're always still welcome to go ahead and submit a PR (as you've done). |
… should come first. (#5919) * First * First * Second * Third * Fourth * Fixes:#5876 * Fixes:5876 * Fixes:5876 * Fixes:5876 * AST Approach * AST Approach * AST Approach * AST Approach * AST Approach * AST Approach * Solved Two Linting Errors * Solved Two Linting Errors * Solved Two Linting Errors * Solved Two Linting Errors * Solved Two Linting Errors * Solved Two Linting Errors * Solved Two Linting Errors * Travis CI was not building * Custom Check for Args Order * Custom Check for Args Order * Custom Check for Args Order * Custom Check for Args Order * Added More Tests and resolved merge conflicts * Added More Tests and resolved merge conflicts * Added More Tests and resolved merge conflicts * Requested changes done * Added fullstop * Added fullstop * Added docstring * Changes made
Check all python functions and make sure if the class args
selforclsappear in the arguments of a function definition, that they are listed first.This logic should probably live in
scripts/pre_commit_linter.py.See this conversation for background: #5844 (comment)
The text was updated successfully, but these errors were encountered: