Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

While running back-end tests, module name in test target should redirect to its test class #5761

Closed
lilithxxx opened this issue Oct 14, 2018 · 3 comments · Fixed by #6014
Closed

While running back-end tests, module name in test target should redirect to its test class #5761

lilithxxx opened this issue Oct 14, 2018 · 3 comments · Fixed by #6014
Labels
backend good first issue

Comments

@lilithxxx
Copy link
Contributor

When running back-end tests, the module name in the --test_target flag should redirect to its test file.
For ex, --test_target='core.controllers.admin' should run --test_target='core.controllers.admin_test'
@seanlip
Copy link
Member

seanlip commented Oct 15, 2018 •
edited
Loading

I just want to say that this is a great idea. I run into this occasionally!

One suggestion: it might be worth displaying a clearly-delineated warning message in the terminal, waiting for 3 seconds, then continuing with execution. That helps the developer realize that they entered the wrong command.

@anubhavsinha98
Copy link
Contributor

Hey @lilithxxx , @apb7 I would like to work on it .

@anubhavsinha98
Copy link
Contributor

anubhavsinha98 commented Dec 20, 2018 •
edited
Loading

Here is the PR !
PTAL !
Thanks !
#6014

@anubhavsinha98 anubhavsinha98 mentioned this issue Dec 20, 2018
Merged
6 tasks
apb7 pushed a commit that referenced this issue Dec 22, 2018
@anubhavsinha98 @apb7
Fixes #5761: --test_target flag will redirect to its test file. (#6014)
02995f8 
* Fixes:5761 test_target issue

* Corrected the if

* Added the warning message

* Changed the warning message

* changed . to -
@rahgurung rahgurung mentioned this issue Jan 6, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #5761: --test_target flag will redirect to its test file. anubhavsinha98/oppia
6 participants
@seanlip @tjiang11 @DubeySandeep @apb7 @anubhavsinha98 @lilithxxx