Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align cards in library in mobile view #5755

Closed
kevinlee12 opened this issue Oct 12, 2018 · 9 comments · Fixed by #5968
Closed

Align cards in library in mobile view #5755

kevinlee12 opened this issue Oct 12, 2018 · 9 comments · Fixed by #5968
Labels
frontend good first issue

Comments

@kevinlee12
Copy link
Contributor

kevinlee12 commented Oct 12, 2018 •
edited
Loading

From #5678, the cards don't line up in mobile view in the library page. The objective of this issue is to align the cards with the headers in mobile view. See #5678 (comment) for how it should look like.

image
@kevinlee12 kevinlee12 mentioned this issue Oct 12, 2018
Closed
@kevinlee12
Copy link
Contributor Author

@nsivapalan, would you like to tackle this?

@nsivapalan
Copy link
Contributor

Sure!

@DubeySandeep
Copy link
Member

Hi @nsivapalan, any update on this issue?

@nsivapalan
Copy link
Contributor

Hi @DubeySandeep, unfortunately I haven't made much progress so far, feel free to re-assign this if someone else wants to work on it.

@geetchoudhary
Copy link
Contributor

geetchoudhary commented Dec 8, 2018 •
edited
Loading

Hi @DubeySandeep @kevinlee12 , Can I work on this issue?

@geetchoudhary geetchoudhary mentioned this issue Dec 10, 2018
Merged
6 tasks
@umasankar1999
Copy link

Hi @kevinlee12 ,I want to work on this issue.
Can you elaborate this issue ? As per I have understood , We need to align the cards and their headings at centre of the page .

@kevinlee12
Copy link
Contributor Author

Hi @umasankar1999, @geetchoudhary is currently working on this issue, would there be another ticket that you are interested in working on?

@umasankar1999
Copy link

Okay @kevinlee12 , Got it !! 👍

@kevinlee12
Copy link
Contributor Author

thanks @umasankar1999!

kevinlee12 pushed a commit that referenced this issue Dec 30, 2018
@geetchoudhary @kevinlee12
Fix #5755: Added padding to cards to fix alignment issue on mobile vi…
ba37cc9 
…ew (#5968)

* Fixed alignment of cards in mobile view

* aligned header with cards

* added support for small devices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5755: Added padding to cards to fix alignment issue on mobile view geetchoudhary/oppia
5 participants
@kevinlee12 @nsivapalan @DubeySandeep @umasankar1999 @geetchoudhary