Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove G+ from the sharing icons (in the exploration editor and in the info card of the exploration player). #5751

Closed
seanlip opened this issue Oct 11, 2018 · 4 comments
Closed

Remove G+ from the sharing icons (in the exploration editor and in the info card of the exploration player). #5751

seanlip opened this issue Oct 11, 2018 · 4 comments
Assignees
@rafalk342
Labels
frontend

Comments

@seanlip
Copy link
Member

seanlip commented Oct 11, 2018 •
edited
Loading

G+ for consumers is getting deprecated. It probably makes sense to remove the corresponding sharing icon and functionality from the following two places:

  • The info card modal in the exploration player page (click the "i" button next to the exploration title)
  • The "congrats, you've published an exploration" modal in the exploration editor page

(Probably worth checking to see if there's anywhere else, too.)
@seanlip seanlip changed the title Remove G+ from the sharing icons (in the exploration editor and at the bottom right of the site). Remove G+ from the sharing icons (in the exploration editor and in the info card of the exploration player). Oct 11, 2018
@mzaman07
Copy link
Contributor

The readme has a google plus link on there as well.

@seanlip
Copy link
Member Author

seanlip commented Oct 12, 2018

Thanks for noting that, @mzaman07! I think it's fine to leave that. Here's the reasoning:

  • There are two usages of G+, I think. One is for individuals to share explorations they like or that they've created. The other is just a pointer to our G+ page. I think the former should go but the latter can remain, since the latter isn't really a "G+ page for consumers" because the Oppia Foundation is an organization.
  • The README page is an example of the latter use, so we can probably leave it.

(I'm not entirely sure though what the exact ramifications of the deprecation are. But I think it's fine to drop the sharing links for now, and we can drop the others later if necessary.)

@GusGu3
Copy link

GusGu3 commented Oct 24, 2018

I am able to do this if nobody else is already working on it

@apb7
Copy link
Contributor

apb7 commented Nov 17, 2018

Hi @GusGu3, are you still interested on working on this? If yes, we will be happy to assign you. Thanks!

@rafalk342 rafalk342 self-assigned this Jan 5, 2019
@rafalk342 rafalk342 mentioned this issue Jan 5, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafalk342 rafalk342

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@rafalk342 @mzaman07 @seanlip @tjiang11 @apb7 @GusGu3