Also /cc @apb7 since this relates to dev workflow.

Note: this is meant to be a count of files, not the size of the files.

Hi, is anyone working in this issue? If not, I would like to work on it. But I have some questions about the task. The explanation says that the script causes a crash in Travis build when there are more than 7k files, I was looking at the others scripts that make Travis build crash and they have a shell script that runs the python script and if it fails then the scripts fails and finally the .travis.yaml builds fails. My question is, the task includes creating that shell scrips and the code necessary in the .travis.yaml or only the python script? Or is there any other way of making the Travis build fail using only the python script? And also, does directories count or just the files?

Hi @tonadev, go for it!

The task includes creating whatever code is needed to achieve the desired result -- i.e. if we get to more than a certain file count then Travis should fail.

Also, only the files count, not the directories.

Thanks!

I think you can include the check in install_third_party.py, after _install_third_party_libs() is run. Does it make sense? (or just run a separate python script after install_third_party.py has finished installing is fine too)

Hi @tonadev, there is a Travis build that runs on every PR. The build for that PR should catch the issue and prevent that PR from being merged (right?) So there shouldn't be a cascading effect on other PRs...

We could also just make this a regular presubmit check, but only if it doesn't take a long time, otherwise it slows down folks a lot.

I'm not sure whether including the check in install_third_party.py suffices though. The developer may just miss the error message...

I realized about that I was wrong, that why supposedly I deleted the comment.