Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove $parent from HTML files #5069

Closed
apb7 opened this issue Jun 9, 2018 · 4 comments · Fixed by #7110
Closed

Remove $parent from HTML files #5069

apb7 opened this issue Jun 9, 2018 · 4 comments · Fixed by #7110
Assignees
@YashJipkate

Comments

@apb7
Copy link
Contributor

apb7 commented Jun 9, 2018

All $parent statements had been removed from the JS files and a check had been implemented for it in PR #4980. A similar thing has to be done for the HTML files. This issue keeps a track of it.
@apb7 apb7 self-assigned this Jun 9, 2018
@vojtechjelinek
Copy link
Contributor

Hi, I'm currently working around extensions/objects/templates and I anyway need to change some of the HTML, so I will also remove the parent tags from there.

@apb7
Copy link
Contributor Author

apb7 commented Jun 9, 2018

Great, thanks @vojtechjelinek!

@apb7 apb7 added devflow and removed backend labels Jun 16, 2018
@jacobdavis11
Copy link
Member

@apb7 any updates on this?

@apb7
Copy link
Contributor Author

apb7 commented Sep 13, 2018

Hi @jacobdavis11, I am not working on this at the moment. Therefore, un-assigning. Thanks!

@apb7 apb7 removed their assignment Sep 13, 2018
@YashJipkate YashJipkate mentioned this issue Jul 7, 2019
Merged
8 tasks
vojtechjelinek pushed a commit that referenced this issue Jul 9, 2019
@YashJipkate @vojtechjelinek
Fix #5069: Remove $parent from codebase. (#7110)
3316974 
* remove $parent.localvalue

* Fix e2e

* Fix FE

* Fix e2e

* Removed .displayedCollectionCategory

* Removed .displayedCollectionTags

* Removed .newCategory

* Removed ..tmpStateName

* Removed .emailBody

* Removed ..customizationArgs

* Fix backend tests

* Added the lint check

* Revert package-lock

* Revert package-lock.json

* Restored permission for hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YashJipkate YashJipkate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5069: Remove $parent from codebase.
4 participants
@vojtechjelinek @jacobdavis11 @apb7 @YashJipkate