Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static checking for pylint in pre_commit_linter.py #4956

Closed
opllama2 opened this issue May 19, 2018 · 0 comments · Fixed by #4957
Closed

Static checking for pylint in pre_commit_linter.py #4956

opllama2 opened this issue May 19, 2018 · 0 comments · Fixed by #4957
Assignees
@apb7

Comments

@opllama2
Copy link

The following is a bug report about linting in the file specified in the title.

  • The expected behaviour: the script should run lints before commiting a change without errors and should have a synced/dynamic checking of the installed version of pylint.

  • The current behaviour: The script fails with an error message "Please run start.sh first to install pylint", the linter checks for pylint-1.7.1 at line 185 while the start.sh script installed pylint-1.8.4

  • OS: MacOS High Sierra V10.13.4

Thanks!
@apb7 apb7 self-assigned this May 19, 2018
@apb7 apb7 mentioned this issue May 19, 2018
Merged
6 tasks
kevinlee12 pushed a commit that referenced this issue May 19, 2018
@apb7 @kevinlee12
Fixes #4956: Change Pylint version (#4957)
8be2cc3 
* Change Pylint version to 1.8.4

* Disable wrong-import-order

* Disable wrong-import-order for pre_commit_linter

* Fix errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apb7 apb7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #4956: Change Pylint version
2 participants
@apb7 @opllama2