Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The dropdown menu for the "Categories" and the "Language" do not close when user presses tab on the last element element or presses shift + tab on the first element in the dropdown menu #4936

Closed
ishucr7 opened this issue May 14, 2018 · 3 comments · Fixed by #5974
Closed

The dropdown menu for the "Categories" and the "Language" do not close when user presses tab on the last element element or presses shift + tab on the first element in the dropdown menu #4936

ishucr7 opened this issue May 14, 2018 · 3 comments · Fixed by #5974
Labels
frontend good first issue needs debugging

Comments

@ishucr7
Copy link
Contributor

ishucr7 commented May 14, 2018

  • The expected behaviour
    The dropdown menus should work similar to what the about and profile dropdown behave with the keyboard. I.e on pressing

  1. tab on the last element, the dropdown must close and the focus should be passed on to the next element.

  2. shift + tab on the first element, the dropdown must close and the focus should be passed on to the previous element.

  • The Observed behaviour
    The dropdown menu for the "Categories" and the "Language" in the search bar in Library, do not close when the user presses shift + tab on the first element in the dropdown menu or presses tab on the last element of the dropdown menu.

  • Steps to reproduce the problem
    Go to the library page, navigate to the "All Categories" and press enter. Using tab button, navigate to the first element in the dropdown. Press shift + tab. The focus shifts to the previous element but it doesn't close the dropdown menu as expected.

Attached is the screen shot-- It shows that we could navigate to another dropdown with the "All Categories" dropdown open.
issue_dropdown

All of the above navigation is done with the help of the keyboard.
For reference look at the issue
And a PR for it's subpart.
@nithusha21
Copy link
Contributor

@srikar0896 could you take a look? (As the initial fix was done by you).

@srikar0896
Copy link
Contributor

@nithusha21 okay.

@geetchoudhary
Copy link
Contributor

I am working on this.

geetchoudhary added a commit to geetchoudhary/oppia that referenced this issue Dec 12, 2018
@geetchoudhary
oppia#4936 adds tab and shift-tab navigation feature
67b9b8b
@geetchoudhary geetchoudhary mentioned this issue Dec 12, 2018
Merged
6 tasks
bansalnitish pushed a commit that referenced this issue Dec 28, 2018
@geetchoudhary @bansalnitish
Fix #4936: The dropdown menus work similar to what the about and prof…
618344f 
…ile dropdown behave with the keyboard. (#5974)

* #4936 adds tab and shift-tab navigation feature

* section now closes when opened with mouseclick

* Removed unwanted functions

* Fixed function issues - added necessary functions

* Added Service

* Added service to top-navigation-bar

* Added NavigationService to aboutMenu

* fixed linting errors

* removed spaces

* removed comments

* made rootScope accessible in html

* removed use of rootScope

* resolved merge conflict

* fixed pattern errors

* changed fileoverview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend good first issue needs debugging
Projects
None yet
Milestone
No milestone
7 participants
@anmolshkl @seanlip @nithusha21 @DubeySandeep @srikar0896 @ishucr7 @geetchoudhary