Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade font-awesome to latest version and update audio play/pause icons #4292

Closed
tjiang11 opened this issue Dec 29, 2017 · 4 comments
Closed

Comments

@tjiang11
Copy link
Contributor

In the audio bar directive, we would like to use fa-play-circle and fa-pause-circle instead of fa-play and fa-pause. However, our current version of font awesome does not include fa-pause-circle.

@srikant-ch5
Copy link

@tjiang11 I would like to work on this..

@1995YogeshSharma
Copy link
Contributor

Hi @sriks123 , please follow the instructions here. Only then I can assign the issue to you.

Also, in general, if the issue is unassigned, you can assign it to yourself and start working.

@seanlip
Copy link
Member

seanlip commented Feb 17, 2018

Hi @sriks123, just a quick note: GitHub doesn't allow us to assign issues to non-collaborators, and we only add people as collaborators after they've successfully completed and merged a couple of PRs (in order to reduce churn). So, to start, you might consider taking one of the starter projects listed here instead, which have already been broken down into components and can be assigned by editing the first comment (or asking an existing contributor to do so).

Note that it's also fine to take up a regular issue, though. Just say in the comments that you've filled in the CLA etc. and are currently working on this issue, then feel free to go ahead and submit a PR for review.

@srikar0896
Copy link
Contributor

@sriks123 still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants