Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "finished an exploration in a collection" experience. #4076

Closed
seanlip opened this issue Nov 11, 2017 · 19 comments
Closed

Fix the "finished an exploration in a collection" experience. #4076

seanlip opened this issue Nov 11, 2017 · 19 comments

Comments

@seanlip
Copy link
Member

seanlip commented Nov 11, 2017

To reproduce: Play https://www.oppia.org/explore/DIWZiVgs0km-?collection_id=4UgTQUc1tala to the end. After it's completed, instead of seeing just the next exploration in the collection, you'll see instead a bunch of randomly-recommended explorations. This is a pretty bad experience -- it means that students would need to go back to the library page, find the collection, click into it, remember and find the next exploration, and click into that to play it. This is likely to result in a significant dropoff rate in continuing the collection.

Instead, for explorations in a collection, there should be a clear link at the end that points to the next lesson in the collection. Based on wireframes from @amitdeutsch, the expected look-and-feel should be as follows (for explorations in a collection):

next in collection

In addition, the experience for explorations outside a collection should be as follows:

next exploration 1

Note that whether an exploration is being played in the context of a collection or not can be determined from the existence of the "collection_id" parameter in the URL bar.

@BenHenning
Copy link
Member

So when investigating this issue, both @seanlip and I were unable to repro the underlying issue of not seeing the correct 'next exploration in the collection' for the logged out case. We need more information on why this was hit before, as it may have been a regression that's since been fixed. The original code to support proper guest continuation in collections was introduced over a year ago.

Given #3708 was submitted a while back, is there any additional work needed here?

@seanlip
Copy link
Member Author

seanlip commented Dec 1, 2017

#3708 was never submitted, so that work is still needed. The current experience in develop does not match the one described above.

@BenHenning
Copy link
Member

Ah I missed that. Okay, thanks

@BenHenning
Copy link
Member

At one point we removed the return to library link, do we want to reintroduce it?

@seanlip
Copy link
Member Author

seanlip commented Dec 1, 2017

Yes, let's follow the design here.

Also, I seem to remember that in some cases we have a "Return to Library" button on the bottom of the main card itself. To clarify, this button should be removed.

@BenHenning
Copy link
Member

Including in the collection case? Shouldn't that still be 'Return to collection' like it is now?

@seanlip
Copy link
Member Author

seanlip commented Dec 1, 2017

Sorry, I just realized the top mock is incorrect. The link at the bottom should be "Return to Collection", not "Return to Library".

(And yes, the button at the bottom of the card should be removed in both cases.)

@BenHenning
Copy link
Member

To clarify one more part: do we want to remove the collection summary card and replace it with the link, or should we keep the summary card in the collection case as well? Happy to provide screenshots if that helps

@seanlip
Copy link
Member Author

seanlip commented Dec 1, 2017

I think I'm confused here, could you provide screenshots?

@BenHenning
Copy link
Member

end_exp_in_collection
end_exp_out_collection

@seanlip
Copy link
Member Author

seanlip commented Dec 1, 2017

Wait, sorry. Where's this "collection summary card" you're referencing? I only see exploration summary cards.

@BenHenning
Copy link
Member

No where, I mixed it up in code with the exp summaries :)

@BenHenning
Copy link
Member

That being said, is this what we want? Note the duplicated 'Return to library'/'Go to library' now present and the updated 'Suggested Next' wording (before it was 'Suggested next')

@seanlip
Copy link
Member Author

seanlip commented Dec 1, 2017

Ah, that's why I was confused :D

If this is a check for intended behavior, then I think this is almost but not quite what we want. Some notes:

  • The globes on the cards just seem to be in the wrong place.
  • The "Go to library" button at the bottom of the card, in the second case, should be removed.

It is fine for "Next" to be capitalized.

@BenHenning
Copy link
Member

Okay so then there are a few deviations from the original mocks if I understand correctly (since they do have a 'Return to Library' link at the bottom).

@BenHenning
Copy link
Member

Also, the globe placement seems unrelated to this. If it's an actual bug, I'll file a new issue to track it.

@seanlip
Copy link
Member Author

seanlip commented Dec 1, 2017

I don't understand? There should be a link at the bottom in all cases. I was referring to removing the button at the bottom of the main exploration card.

And yeah, the globes should be on the top right. See #2943 for the expected position.

@BenHenning
Copy link
Member

Ah I misread your statement. Removing the button and filing a separate issue for the globe placement regression.

@BenHenning
Copy link
Member

Filed #4131 to track the globe issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants