Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reordering 'play later' explorations in learner dashboard looks strange #3972

Closed
tjiang11 opened this issue Oct 14, 2017 · 1 comment · Fixed by #6030
Closed

Reordering 'play later' explorations in learner dashboard looks strange #3972

tjiang11 opened this issue Oct 14, 2017 · 1 comment · Fixed by #6030
Assignees
@mighty-phoenix
Labels
frontend important

Comments

@tjiang11
Copy link
Contributor

The dragging and dropping in the play later list on the learner dashboard is kind of wonky. When you drag the item you’re dragging appears at a vertical offset far from the cursor. This looks similar to the problem with drag and drop hints (#3773)

To reproduce:

  1. Go to the library and mark at least two explorations as play later (the little clock icon at the top right corner of the preview cards)
  2. Now go to the learner dashboard and go to the play later tab. Try reordering the explorations and see that sometimes an element being dragged will appear offset vertically.

Note: This seems to occur only in certain window sizes.
@nithusha21
Copy link
Contributor

Hi. I tried reproducing this issue after the jquery-ui upgrade(which fixed #3773) but it seems to still persist. I think the root cause is not the same for both. This issue happened for me on mobile view only. In that view when the page is loaded itself the exploration description has a vertical offset(maybe because it overflows the width, not sure). While you try to reorder the panel seems to jump to where the text was before(with that offset). So possibly fixing the text offset might help.

@DubeySandeep DubeySandeep mentioned this issue May 13, 2018
Closed
@mighty-phoenix mighty-phoenix self-assigned this Dec 25, 2018
mighty-phoenix added a commit to mighty-phoenix/oppia that referenced this issue Dec 25, 2018
@mighty-phoenix
Fix oppia#3972: Fixed the faulty vertical offset
225e15a
@mighty-phoenix mighty-phoenix mentioned this issue Dec 25, 2018
Merged
6 tasks
bansalnitish pushed a commit that referenced this issue Dec 29, 2018
@mighty-phoenix @bansalnitish
Fix #3972: Fixed the faulty vertical offset (#6030)
b25965c 
* Fix #3972: Fixed the faulty vertical offset

* Correction

* Correction

* Correction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mighty-phoenix mighty-phoenix

Labels
frontend important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3972: Fixed the faulty vertical offset mighty-phoenix/oppia
5 participants
@1995YogeshSharma @seanlip @tjiang11 @nithusha21 @mighty-phoenix