Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title bar dropdown menu buttons stay highlighted when clicked and not being hovered #3800

Closed
mikechoch opened this issue Aug 24, 2017 · 1 comment
Closed

Title bar dropdown menu buttons stay highlighted when clicked and not being hovered #3800

mikechoch opened this issue Aug 24, 2017 · 1 comment
Assignees
@anurag545
Labels
frontend

Comments

@mikechoch
Copy link

Currently when you hover over a button on the title bar it highlights white, which is expected. Normal buttons will allow being clicked and it will navigate to whatever page they are linked to. However, there are also the dropdown menu buttons and when they are hovered they highlight and dropdown a menu of other buttons. If you click on one of the dropdown menu buttons the white highlighting will remain if you are not hovering over the button anymore. Since these buttons activate when hovered over, they should be forced into a non-clickable state so that they do not remain white when clicked and no longer hovered.

Ex). The "About" button in the Title Bar drops down a menu with several other buttons. If you click the "About" button and then no longer hover the "About" button it will remain highlighted white.

Normal State
screen shot 2017-08-24 at 7 57 04 am

Hovered State
screen shot 2017-08-24 at 7 57 21 am

Clicked and Not Hovered State
screen shot 2017-08-24 at 7 57 29 am
@mikechoch mikechoch changed the title Title bar dropdown menu buttons stay highlighted when clicked and not being hovered Title bar dropdown menu buttons stay highlighted when clicked and not being hovered loc:frontend Aug 24, 2017
@mikechoch mikechoch changed the title Title bar dropdown menu buttons stay highlighted when clicked and not being hovered loc:frontend Title bar dropdown menu buttons stay highlighted when clicked and not being hovered Aug 24, 2017
anurag545 pushed a commit to anurag545/oppia that referenced this issue Sep 10, 2017
Issue oppia#3800 dropdown click about focus error
177a190
@anurag545 anurag545 mentioned this issue Sep 10, 2017
Merged
@anurag545
Copy link

PR #3855 solves this issue.

giritheja added a commit to giritheja/oppia that referenced this issue Sep 17, 2017
@giritheja
Merge remote-tracking branch 'upstream/develop' into questions-projec…
71fb33d 
…t-m2

* upstream/develop: (27 commits)
  Fixes 3687: batch call for exploration and exploration rights object together. (oppia#3815)
  Fix part oppia#3400 Objective field directive (oppia#3740)
  Fix oppia#3800 Dropdown menu of the ABOUT in navigation bar (oppia#3855)
  Fix oppia#3295 Save draft change list to local storage. (oppia#3584)
  Disable learner dashboard feedback updates send button when no text entered. (oppia#3860)
  Disable save button while uploading audio to server; add Spanish support to audio languages; add audio loading message to learner view (oppia#3856)
  Fix oppia#3834: Introduce backend event models to record statistics (oppia#3841)
  Fix oppia#3852: Fix failing e2e test in develop (oppia#3853)
  Fix oppia#3826: Move validatorsService from app.js to ValidatorsService.js (oppia#3847)
  Update the max RAND limit for ID generation to fit within 32 bits. (oppia#3843)
  Fix oppia#3404: Add default placeholder text for mobile devices  (oppia#3845)
  Fix oppia#2553: Change the "index all explorations" job in the admin dashb… (oppia#3831)
  Add I18N to give up button; change tooltip text. (oppia#3844)
  Fix oppia#3721: Update the release_info script to use LCA and the most recent release tag in order to compile the list of changes, rather than relying on git describe. (oppia#3838)
  show_warning_only_on_button_click (oppia#3833)
  Deprecate splash page experiment (oppia#3829)
  Fixes for end to end working between Oppia and Oppia-ml. (oppia#3824)
  Fix 'Empty path passed in method' error on the collection page. (oppia#3827)
  Learner dashboard 3.2 (oppia#3759)
  📝 Fix oppia#3789 :Space out the profile drop down icons (oppia#3789). (oppia#3817)
  ...
@seanlip seanlip assigned anurag545 and unassigned mikechoch Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anurag545 anurag545

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AllanYangZhou @anurag545 @mikechoch