Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer loading of visualization JS scripts in the exploration editor. #2639

Closed
seanlip opened this issue Oct 25, 2016 · 7 comments
Closed

Defer loading of visualization JS scripts in the exploration editor. #2639

seanlip opened this issue Oct 25, 2016 · 7 comments
Assignees
@makoscafee
Labels
frontend

Comments

@seanlip
Copy link
Member

seanlip commented Oct 25, 2016

(Originally filed in #2391 by @gvishal)

In the exploration editor, corechart requires 600ms to parse and another 80ms to compile + execute. We should add the "async" attribute to js scripts that are not critical (e.g. visualizations, analytics) so that they don't block page loading.

Also, see this reference for information on how to improve performance of a webpage by identifying critical resources.
@seanlip seanlip mentioned this issue Oct 25, 2016
Closed
@seanlip seanlip modified the milestone: Recommended projects Jan 25, 2017
@seanlip
Copy link
Member Author

seanlip commented May 15, 2017 •
edited
Loading

@Slayslot, would you mind looking into this and advising on what needs to be done here? Maybe this will also help get rid of these warnings in Chrome, which I think might be related:

browser-console

Thanks!

@handasolo
Copy link

@seanlip Sure thing. I'll take a look into it.

@seanlip
Copy link
Member Author

seanlip commented May 23, 2017

Hi @Slayslot! How's this going? Did you manage to figure out what's going on here?

@tjiang11
Copy link
Contributor

@Slayslot ping?

@handasolo
Copy link

Hi @seanlip @tjiang11, Apologies it has been some busy days at work for me. I did take a look at this and wasn't able to figure out how to get google.load to defer loading of the corechart js file. I'll take a look into it again.

@seanlip
Copy link
Member Author

seanlip commented May 30, 2017

I wonder if others have come across the same issue. Maybe search for the error message (in conjunction with corechart)?

@seanlip
Copy link
Member Author

seanlip commented Jun 30, 2017

Deassigning @Slayslot due to lack of response (including via email).

@seanlip seanlip assigned makoscafee and unassigned handasolo Jun 30, 2017
giritheja added a commit to giritheja/oppia that referenced this issue Jul 16, 2017
@giritheja
Merge remote-tracking branch 'upstream/develop' into publish-modal-up…
ecdadef 
…date

* upstream/develop: (32 commits)
  Remove erroneous clause in app.yaml. (oppia#3643)
  Part of oppia#2447: Upgrade select2 library (oppia#3626)
  Fix part of oppia#2394: Added docstrings in exp_domain.py (oppia#3578)
  Fix oppia#3618: stop icon overlap (oppia#3642)
  Add backend functionality to correctly handle needs_update part of subtitled HTML. (oppia#3620)
  Change 'style' to 'ng-attr-style' in an attempt to fix IE bug in collection viewer. (oppia#3636)
  Fix typo in Exploration editor (oppia#3637)
  Update credits (oppia#3633)
  Fix oppia#2639: Updated Google chart/visualization Library loader code and use async to load the library (oppia#3614)
  Fix user bios job in the case that user_bio is None (oppia#3632)
  Update changelog and credits for release 2.5.2 (oppia#3628)
  Fix oppia#2394: Add docstring to core.domain.user_jobs_continous.py (oppia#3569)
  Fix oppia#3585: Corrected arrows in exploration progress nav (oppia#3605)
  change the text
  edit error message
  Corrected tense of error message
  Corrected state to read card
  Close modal window if clicked outside (oppia#3623)
  Storage, Domain classes and helper functions for ClassifierExplorationMapping (oppia#3583)
  removed super admin role from admin interface. (oppia#3621)
  ...
@seanlip seanlip modified the milestone: Recommended projects Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@makoscafee makoscafee

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@handasolo @makoscafee @seanlip @tjiang11