Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Notify developer onboarding leads about new contributors merged PRs #20381

Closed
HardikGoyal2003 opened this issue May 31, 2024 · 6 comments
Closed

[Feature Request]: Notify developer onboarding leads about new contributors merged PRs #20381

HardikGoyal2003 opened this issue May 31, 2024 · 6 comments
Assignees
@HardikGoyal2003
Labels
enhancement Label to indicate an issue is a feature/improvement

Comments

@HardikGoyal2003
Copy link
Member

Is your feature request related to a problem? Please describe.

We have noticed that numerous new contributors merge 1 PR and then cease contributing. We seek to understand the reasons behind this behavior from the contributors. At times, new contributors merge 2 PRs but overlook filling out the collaborator form, leading to the loss of valuable contributors from the community.

Describe the solution (or solutions) you'd like

Writing a GitHub action for developer onboarding leads that can help them get a notification whenever a new contributor has merged two PRs or they can contact the person.

Describe alternatives you've considered and rejected

No response

Additional context

No response
@HardikGoyal2003 HardikGoyal2003 added triage needed enhancement Label to indicate an issue is a feature/improvement labels May 31, 2024
@HardikGoyal2003
Copy link
Member Author

@AFZL210 PTAL! Thanks!

@AFZL210
Copy link
Contributor

AFZL210 commented May 31, 2024 •
edited
Loading

@HardikGoyal2003 This looks good. how do you plan to notify? tag them in the PR description or have a discussion like we have one for pending reviews https://github.com/oppia/oppia/discussions/18759 ?

@HardikGoyal2003
Copy link
Member Author

@AFZL210 I am thinking of tagging them in the PR description. When the contributor merges the 1st PR, I will be notified and will add their email to the excel. When the 2nd PR gets merged, you will be notified so you can email them, inform them, and ask them to fill out the collaborator form. What do you think about this plan?

@AFZL210
Copy link
Contributor

AFZL210 commented May 31, 2024 •
edited
Loading

@AFZL210 I am thinking of tagging them in the PR description. When the contributor merges the 1st PR, I will be notified and will add their email to the excel. When the 2nd PR gets merged, you will be notified so you can email them, inform them, and ask them to fill out the collaborator form. What do you think about this plan?

Yes sounds good. we only want to do this if the contributor has less than 2 PRs

@HardikGoyal2003 HardikGoyal2003 mentioned this issue May 31, 2024
Closed
5 tasks
@HardikGoyal2003
Copy link
Member Author

@AFZL210 Yeah that's why I just added for 1st and 2nd merge of PRs.

@HardikGoyal2003 HardikGoyal2003 mentioned this issue Jul 16, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Aug 7, 2024
@HardikGoyal2003
Fix #20381 : Added Github Action for developer Onboarding leads (#20683)
2f3683c 
* Added developer notification

* Made minor changes

* Added intermediate env variable

* removed name

* Added env approach

* Added exception in linters
@github-project-automation github-project-automation bot moved this from Todo to Done in Developer Workflow Team Aug 19, 2024
@HardikGoyal2003
Copy link
Member Author

Completed with #20683

@HardikGoyal2003 HardikGoyal2003 mentioned this issue Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HardikGoyal2003 HardikGoyal2003

Labels
enhancement Label to indicate an issue is a feature/improvement
Projects
Developer Workflow Team
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seanlip @AFZL210 @HardikGoyal2003