Collections should have a language code #1697
Comments
|
Adding an additional note for context: currently, the collection editor does not have a concept of warnings. It issues either warnings through the alerts service (which are essentially hard failures) or enumerates validation errors, which must be fixed before saving the collection. The warning for the language code should be a soft warning, meaning the editor should not prevent the collection from being saved if the warning is present, even if the collection is published. Also, the collection editor does not currently have a functional settings tab, but it will soon. :) |
|
Hi @hitesh96db, would you be interested in looking into this? |
|
Sure :) |
|
Thanks! Assigned you :-) |
|
Btw this comment explains how to get started with collections: #1587 (comment) |
|
Note: my previous comment is no longer true. We now have a CollectionValidatorService for doing the check Sean mentioned. |
|
Since this is now blocking #1630, I'm going to take it over. |
Currently, explorations have language codes specified (in addition to title, objective, etc.) whereas collections don't. However, in order to determine which collections to show to users requesting learning material in a particular language, we'll need to know the language codes of the collections.
The aim of this issue is therefore to add a language code property to the collection storage model. It should mimic that for explorations. In addition, it should be possible for authors of collections to set the language code explicitly in the collection editor's settings tab.
We might also want to add a warning within the collection editor if a constituent exploration has a language code that's different from the collection's language code.
/cc @BenHenning
The text was updated successfully, but these errors were encountered: