-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the first major design iteration of the collection editor #1464
Comments
@BenHenning -- maybe post your mocks here at some point? |
A few quick questions:
|
Thanks for the feedback @jacobdavis11.
|
@amgowano, can you break down the work needed to complete this task? You're tackling some of the features in #1687, but it would be great to see an enumeration of all the work that's needed. If you can, please group the items into buckets representing PRs. For instance, in #1687 you have implemented the collection node graph with deletion functionality and removed the current node list. #1687 should also include displaying the collection nodes in their play order and updating the sample collection YAML to have a linear progression. The other tasks needed to finish this can be split up into future PRs. Thanks! |
Implementation breakdown:
|
Hi @amgowano, any updates on this issue? Thanks! |
Fix part of #1464: implement the collection editor node list (PR 1/2; this is to bring Abe's changes into the central Oppia respository)
Provides a base implementation for the collection editor node list without dragging being used for scrolling.
…pia#1993) Provides a base implementation for the collection editor node list without dragging being used for scrolling.
The style of the editor looks very stark, and does not match the style used by the exploration editor. In order to fix this, the collection editor should be setup to better match the exploration editor in workflow and design as a baseline. A final, first iteration needs to be designed and implemented as part of this issue.
This issue should also address some concerns @jacobdavis11 brought up to help avoid user confusion:
Those specific recommendations do not need to be implemented as part of this issue, but the problems they caused should be addressed by whichever solution fixes this issue.
These originally came from #1462. Furthermore, the work in #1462 is primarily validation and error functionality. This issue includes ensuring the errors are nicely displayed to the user.
Here are the second versions of the hand-drawn mocks for the first major iteration of the collection editor. @amgowano, @seanlip , and @xtyang have all contributed ideas and/or reviewed these.
This issue involves implementing the above mocks. A more detailed technical breakdown needs to be done.
The text was updated successfully, but these errors were encountered: