-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for MAX_COMMIT_MESSAGE_LENGTH
#11693
Comments
@vojtechjelinek is this issue already resolved? |
@vojtechjelinek I would like to work on this issue. |
@vojtechjelinek Can you tell me where should I start with? Thanks! |
@hardikkat24 Hi, you will need to modify oppia/core/domain/base_model_validators.py Line 694 in 619c620
oppia/core/domain/base_model_validators.py Line 779 in 619c620
commit_message field in BaseSnapshotMetadataModel and BaseCommitLogEntryModel .
If this explanation is not enough please let me know. |
@vojtechjelinek Thanks a lot! I have done as you said. But I have some questions:
|
|
@vojtechjelinek Thanks a lot! Now I should test this code. So this can be done by adding tests in |
@hardikkat24 Okay, put the tests in prod_validators_test.py, we can discuss any move of these tests to other places once you open a PR. |
@vojtechjelinek After I add the tests, then only the Jobs will show whether my approach was correct or not. Am I correct on this? Or can I test my approach without adding tests in the file. |
As I said "you start the local server, log in as admin, navigate to admin page and the jobs tab, run the jobs there". |
Add validation for the maximum commit length (
MAX_COMMIT_MESSAGE_LENGTH
) to the commit logs and snapshot metadata models.The text was updated successfully, but these errors were encountered: