Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding @jeremyeder fixes we missed #49

Merged
merged 1 commit into from
Oct 25, 2022
Merged

adding @jeremyeder fixes we missed #49

merged 1 commit into from
Oct 25, 2022

Conversation

quaid
Copy link
Member

@quaid quaid commented Oct 25, 2022

No description provided.

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 25, 2022
@quaid
Copy link
Member Author

quaid commented Oct 25, 2022

/assign @jeremyeder @schwesig

schwesig
schwesig approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@schwesig schwesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2022
@schwesig
Copy link
Contributor

/approve

@schwesig schwesig added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2022
@sesheta
Copy link
Member

sesheta commented Oct 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: schwesig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta merged commit fbc9b36 into operate-first:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schwesig schwesig schwesig approved these changes

Assignees

@jeremyeder jeremyeder

@schwesig schwesig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quaid @schwesig @sesheta @jeremyeder