Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup pass to consolidate markdownlint and spelling corrections #37

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

lisa
Copy link
Contributor

@lisa lisa commented Oct 5, 2022

This change will address the spelling errors that slipped past on iniital reviews and hopefully has caught them all. There is a mix of British and English spelling which I did not correct one way or another.

The larger changes have to do with markdownlint. As mentioned in the README.md's contributing section, we wish for markdownlint to be used. I disabled rule 37 because we have an explicit use case of it that I am not prepared to change at this time (this change is not meant to change content or presentation).

lisa added 2 commits October 5, 2022 14:13
One spelling error fixed in the bootstrap guide. Another commit will address spelling and other formatting issues in other documents.
There is a mix of British and American English (still) and I'm not quite
sure how to handle it; there is no consensus or discussion on the topic
as of yet.

Signed-off-by: Lisa Seelye <lisa@users.noreply.github.com>
@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 5, 2022
@lisa lisa requested review from mmazur and brizrobbo October 5, 2022 18:48
@jeremyeder
Copy link
Contributor

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2022
@lisa
Copy link
Contributor Author

lisa commented Oct 5, 2022

/approve

@sesheta
Copy link
Member

sesheta commented Oct 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lisa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2022
@sesheta sesheta merged commit f636488 into operate-first:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants