Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix a typo and reorder the introduction of SLO and SLI" #36

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

lisa
Copy link
Contributor

@lisa lisa commented Oct 5, 2022

Reverts #34

As discussed on Slack:

The ordering of SLO and SLI in the bootstrap guide was intentional. The philosophy behind it will be included into the SLO Lifecycle guide; the typo that Ben corrected here will also be fixed in a subsequent PR.

@sesheta
Copy link
Member

sesheta commented Oct 5, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lisa by writing /assign @lisa in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 5, 2022
@jeremyeder
Copy link
Contributor

/lgtm

@lisa
Copy link
Contributor Author

lisa commented Oct 5, 2022

I guess the bot isn't going to merge from Jeremy's /lgtm? Alright...

@lisa lisa merged commit b05cd74 into main Oct 5, 2022
@lisa lisa deleted the revert-34-patch-1 branch October 5, 2022 13:32
@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants