Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new KafkaUser for cluster logging #770

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Create new KafkaUser for cluster logging #770

merged 1 commit into from
Jun 22, 2021

Conversation

4n4nd
Copy link
Contributor

@4n4nd 4n4nd commented Jun 18, 2021

Add kafka creds to ClusterLogForwarder
Add Kafka tls creds to vector

Create new KafkaUser for cluster logging
6771c4f 
Add kafka creds to ClusterLogForwarder
Add Kafka tls creds to vector
@4n4nd 4n4nd requested a review from HumairAK June 18, 2021 14:45
@sesheta sesheta requested a review from harshad16 June 18, 2021 14:45
@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 18, 2021
tumido
tumido reviewed Jun 21, 2021
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2021
HumairAK
HumairAK approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@HumairAK HumairAK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta
Copy link
Member

sesheta commented Jun 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2021
@sesheta sesheta merged commit e7ae604 into operate-first:master Jun 22, 2021
@4n4nd 4n4nd mentioned this pull request Jun 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tumido tumido tumido left review comments

@HumairAK HumairAK HumairAK approved these changes

@harshad16 harshad16 Awaiting requested review from harshad16

Assignees

@tumido tumido

@HumairAK HumairAK

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@4n4nd @sesheta @tumido @HumairAK