Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Match ghproxy resource request and limit #2625

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

tumido
Copy link
Member

@tumido tumido commented Nov 16, 2022

After #2619 it seems ghproxy has stabilized. Utilization is below request so let's match limits to request.

Memory utilization averages around 50Mi and CPU around 2m. I think 128Mi and 10m (matching the limit to request values) is quite generous with a large enough buffer.

Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
@tumido
Copy link
Member Author

tumido commented Nov 16, 2022

/cc @codificat

@sesheta sesheta requested a review from codificat November 16, 2022 17:14
@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 16, 2022
@codificat
Copy link
Member

That's great, thanks!

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022
@sesheta
Copy link
Member

sesheta commented Nov 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2022
@sesheta sesheta merged commit 1bd457b into operate-first:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants