feat(json-format): lowercase span name and service name as per swagger definition #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basvanbeek
approved these changes
Aug 4, 2020
jcchavezs
force-pushed
the
lowercase_span_name_and_service_name
branch
7 times, most recently
from
8a7ca06 to
284481c
Compare
cuonglm
added a commit
to pomerium/pomerium
that referenced
this pull request
Aug 17, 2020
Test needs to be changed to use lowercase name, as required by zipkin JSON API v2 spec. See: openzipkin/zipkin-go#166
5 tasks
cuonglm
added a commit
to pomerium/pomerium
that referenced
this pull request
Aug 17, 2020
Test needs to be changed to use lowercase name, as required by zipkin JSON API v2 spec. See: openzipkin/zipkin-go#166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just discovered the JSON V2 API expected the service names and the span names to be lower case. This PR address that.
https://zipkin.io/zipkin-api/\#/default/post_spans.
Ping @basvanbeek