openstack/02b-MAChigh/msf.h: add ifndef guards #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe @TimothyClaeys can take a look? |
|
@fjmolinas I think it is a good idea to make it easy to customize these values during compile time. Maybe you can add the ifdef guards to the |
TimothyClaeys
requested changes
Oct 27, 2020
There was a problem hiding this comment.
Maybe add:
#ifndef MSF_MAX_NUMCELLS
#define MSF_MAX_NUMCELLS 32
#endif
to the config.h file and replace the defines here with:
#ifndef MSF_MAX_NUMCELLS
#define MAX_NUMCELLS 32
#else
#define MAX_NUMCELLS MSF_MAX_NUMCELLS
#endif
In the config.h these values only are useful when ADAPTIVE_MSF is active. So maybe add an #if guard like we did for the OPENWSN_6LO_FRAGMENTATION_C options
fjmolinas
force-pushed
the
pr_msf_guards
branch
from
6561aab to
023358c
Compare
|
Done, lets see what travis says |
fjmolinas
force-pushed
the
pr_msf_guards
branch
from
023358c to
68c6b0a
Compare
|
@TimothyClaeys all green here! |
TimothyClaeys
approved these changes
Oct 27, 2020
|
Thanks of the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds some ifndef guards to allow easily modifying the values of the msf algorithm.