Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: use ifndef guards for config.h variables + remove deprecated options, e.g., FreeRTOS #518

Merged
merged 20 commits into from
Aug 31, 2020

Conversation

fjmolinas
Copy link
Contributor

This PR replaces:

// #define OPENWSN_% (0)

by

#ifndef OPENWSN_%
#define OPENWSN_% (0)
#endif

It then replaces all the conditionals accordingly to not check if the Macro is defined but if it is "active" (value 1)

This PR is based on top of #514.

@fjmolinas
Copy link
Contributor Author

@TimothyClaeys might want to take a look :)

@TimothyClaeys
Copy link
Member

TimothyClaeys commented Aug 27, 2020

@fjmolinas @changtengfei I updated this PR:

  • Remove some deprecated code (e.g., FreeRTOS)
  • Remove deprecated options (e.g., ide option)
  • Remove tools folder and .project file
  • Add compile flags to include apps, software modules, stack configuration and board options from the command line

Example: scons board=openmote-cc2538 toolchain=armgcc modules=udp,coap apps=cjoin boardopt=hw-crypto stackcfg=adaptive-msf oos_openwsn.

@fjmolinas
Copy link
Contributor Author

@fjmolinas @changtengfei I updated this PR:

Feel free to force push if you want, or to open another PR that includes these changes!

@TimothyClaeys TimothyClaeys changed the title treewide: use ifndef guards for config.h variables treewide: use ifndef guards for config.h variables + remove deprecated options, e.g., FreeRTOS Aug 31, 2020
@changtengfei changtengfei merged commit 94997d0 into openwsn-berkeley:develop Aug 31, 2020
@fjmolinas fjmolinas deleted the pr_config_guards branch September 3, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants